From 70b73f98abeaf2a9f736e15e002645902029d131 Mon Sep 17 00:00:00 2001 From: Charlie Luo Date: Fri, 22 May 2026 20:14:32 -0400 Subject: [PATCH] ref(api): type nullable fields in the base group serializer (#116068) For unshared / unassigned issues, the actual response from the API for endpoints using the BaseGroupSerializerResponse was null. Type that correctly in the serializer Co-authored-by: Claude --- src/sentry/api/serializers/models/group.py | 4 ++-- src/sentry/api/serializers/models/group_stream.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sentry/api/serializers/models/group.py b/src/sentry/api/serializers/models/group.py index 9e40c9864a92..2ddb6413f5d9 100644 --- a/src/sentry/api/serializers/models/group.py +++ b/src/sentry/api/serializers/models/group.py @@ -111,7 +111,7 @@ class BaseGroupResponseOptional(TypedDict, total=False): class BaseGroupSerializerResponse(BaseGroupResponseOptional): id: str - shareId: str + shareId: str | None shortId: str title: str culprit: str | None @@ -134,7 +134,7 @@ class BaseGroupSerializerResponse(BaseGroupResponseOptional): issueCategory: str metadata: dict[str, Any] numComments: int - assignedTo: ActorSerializerResponse + assignedTo: ActorSerializerResponse | None isBookmarked: bool isSubscribed: bool subscriptionDetails: SubscriptionDetails | None diff --git a/src/sentry/api/serializers/models/group_stream.py b/src/sentry/api/serializers/models/group_stream.py index 5ba1f3983eb5..befe4a8cf2ef 100644 --- a/src/sentry/api/serializers/models/group_stream.py +++ b/src/sentry/api/serializers/models/group_stream.py @@ -281,7 +281,7 @@ class _Filtered(TypedDict): class StreamGroupSerializerSnubaResponse(TypedDict): id: str # from base response - shareId: NotRequired[str] + shareId: NotRequired[str | None] shortId: NotRequired[str] title: NotRequired[str] culprit: NotRequired[str | None] @@ -304,7 +304,7 @@ class StreamGroupSerializerSnubaResponse(TypedDict): issueCategory: NotRequired[str] metadata: NotRequired[dict[str, Any]] numComments: NotRequired[int] - assignedTo: NotRequired[ActorSerializerResponse] + assignedTo: NotRequired[ActorSerializerResponse | None] isBookmarked: NotRequired[bool] isSubscribed: NotRequired[bool] subscriptionDetails: NotRequired[SubscriptionDetails | None]