Skip to content

Commit d341ba6

Browse files
committed
Fix KD experiment path collision between FP32 and BitNet students
- Use version-specific prefix (std_kd vs bit_kd) for KD experiments - Pass version parameter from train_kd.py to get_experiment_dir() - Resolves collision where Phase 2 (FP32+KD) and Phase 2.9 (BitNet+KD) were writing to the same bit_kd_s* directories - Existing Phase 2 experiments need manual rename: bit_kd_* → std_kd_*
1 parent 8c1ca82 commit d341ba6

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

experiments/paths.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ def get_experiment_dir(
8585
if lr != TRAINING_DEFAULTS.lr:
8686
parts.append(f"lr{lr:g}")
8787
else:
88-
parts.append("bit_kd")
88+
# Use version-specific prefix for KD experiments (std_kd vs bit_kd)
89+
kd_prefix = f"{version}_kd"
90+
parts.append(kd_prefix)
8991
if ablation != TRAINING_DEFAULTS.ablation:
9092
parts.append(ablation)
9193
if optimizer != TRAINING_DEFAULTS.optimizer:

experiments/train_kd.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,13 @@ def main() -> None:
281281

282282
# Auto-generate output dir if not specified
283283
if not args.output_dir:
284+
version_str = "std" if args.student_is_fp32 else "bit"
284285
experiment_dir = get_experiment_dir(
285286
ExperimentType.KD,
286287
args.dataset,
287288
args.model,
288289
args.seed,
290+
version=version_str,
289291
ablation=args.ablation,
290292
lr=args.lr,
291293
optimizer=args.optimizer,

0 commit comments

Comments
 (0)