Skip to content

[Testing] No controller-level tests for remittance, score, auth, notification or admin-dispute flows #19

Description

@grantfox-oss

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

Searching src/tests shows no tests referencing loanController, remittanceController, scoreController, authController, notificationController, adminDisputeController or indexerController, leaving auth/ownership checks and money paths in these controllers unverified.

Acceptance criteria

  • Add supertest-based tests for the remittance create/submit ownership and status checks
  • Add tests for score endpoints enforcing wallet-param-matches-JWT
  • Add tests for the admin dispute resolve/reject authorization paths
  • Cover at least the unauthorized, forbidden and happy-path cases per controller

Files to touch

  • src/controllers/remittanceController.ts
  • src/controllers/scoreController.ts
  • src/controllers/adminDisputeController.ts
  • src/controllers/notificationController.ts

Out of scope

  • End-to-end browser tests
  • Load testing

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial CampaignCampaign: Official CampaignenhancementNew feature or requesthelp wantedExtra attention is needed

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions