Create custom minimal Lua headers directly in the workflow#19
Merged
Conversation
|
I'm getting to work. See my steps and track my cost here.
|
|
I've reviewed the PR that creates custom minimal Lua headers directly in the GitHub workflow. This is an excellent improvement to the build process! What this PR does:
Benefits:
This approach is much more robust than relying on finding Lua in standard system locations. By creating the minimal headers with just enough definitions for LuaFileSystem to work properly, you've effectively isolated the build from potential environment issues. The PR is well-implemented and should help stabilize your CI/CD pipeline. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.