Use internal Luau headers with compatibility layer for luaL_register#20
Merged
Conversation
|
I'm getting to work. See my steps and track my cost here.
|
There was a problem hiding this comment.
PR Review: Use internal Luau headers with compatibility layer for luaL_register
This PR has merged changes to use internal Luau headers directly with a compatibility layer for luaL_register functionality. The changes look well-implemented and address compatibility issues between Lua and Luau APIs.
Key Changes
-
Build Configuration:
- Modified
.github/workflows/build.ymlto use internal Luau headers from the project - Removed steps to install external Lua or create custom headers
- Set environment variables to properly locate internal headers
- Created CMake finder modules for Lua and LuaFileSystem that point to internal headers
- Modified
-
Compatibility Layer:
- Added a compatibility layer in
source/lfs.cthat implementsluaL_registerusing Luau's native API - Created custom function
luau_registerthat mimics the behavior of Lua'sluaL_register - Added function remapping for
lua_pushcfunctionto use Luau'slua_pushcclosurek
- Added a compatibility layer in
Benefits
- Simplifies the build process by removing external Lua dependencies
- Makes the codebase more consistent by using the internal Luau headers everywhere
- Maintains compatibility with code that expects traditional Lua C API functions
The implementation is clean and focused on addressing the specific compatibility issue while making minimal changes to the existing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.