From 7123cdf7c5e4f9f11349e0dd51f422c242651ed0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dorian=20Oszcz=C4=99da?= Date: Thu, 16 Apr 2026 16:17:53 +0100 Subject: [PATCH 1/2] fix: Prompts and notices ending up in an endless loop of getting created and deleted. --- source/library/services/notices/service.ts | 7 ++++++- source/library/services/prompts/service.ts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/source/library/services/notices/service.ts b/source/library/services/notices/service.ts index 4012c50b3..0473e4057 100644 --- a/source/library/services/notices/service.ts +++ b/source/library/services/notices/service.ts @@ -155,8 +155,13 @@ abstract class NoticeService extends Loca return; } + // If embeds are absent from the update payload (partial update unrelated to embeds), do nothing. + if (message.embeds === undefined) { + return; + } + // If the embed is still present, it wasn't an embed having been deleted. Do not do anything. - if ((message.embeds?.length ?? 0) > 0) { + if (message.embeds.length > 0) { return; } diff --git a/source/library/services/prompts/service.ts b/source/library/services/prompts/service.ts index af6841dac..34e951177 100644 --- a/source/library/services/prompts/service.ts +++ b/source/library/services/prompts/service.ts @@ -286,8 +286,13 @@ abstract class PromptService< return; } + // If embeds are absent from the update payload (partial update unrelated to embeds), do nothing. + if (message.embeds === undefined) { + return; + } + // If the embed is still present, it wasn't an embed having been deleted. Do not do anything. - if (message.embeds?.length === 1) { + if (message.embeds.length === 1) { return; } From 4b50b3b2dec1351f4e645925c4907fccbf512a24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dorian=20Oszcz=C4=99da?= Date: Thu, 16 Apr 2026 16:28:00 +0100 Subject: [PATCH 2/2] chore: Add changelog entry. --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4c0f6e818..a22fe2ee2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## Next (WIP) + +- Fixed notices getting created and deleted in a loop. + ## 5.1.0 - Fixed modal composers not passing through the right data.