test: enhance AuthController and AuthService unit tests with additional mocks

- Added mocks for getLocalBruteforceBlock and hasWebAuthnKeyForUser in AuthController tests to improve test coverage and behavior clarity.
- Introduced redisTtl and redisIncr mocks in AuthService tests to simulate Redis interactions, enhancing the reliability of unit tests.
- Updated beforeEach hooks to set default return values for new mocks, ensuring consistent test environments.

Author: tacxou

apps/api/tests/unit/core/auth/auth.controller.spec.ts

@@ -3,7 +3,9 @@ import { AuthController } from '~/core/auth/auth.controller';
 describe('AuthController', () => {
   const createTokens = jest.fn();
   const authenticateWithLocal = jest.fn();
+  const getLocalBruteforceBlock = jest.fn();
   const isTotpEnabledForUser = jest.fn();
+  const hasWebAuthnKeyForUser = jest.fn();
   const createMfaChallenge = jest.fn();
   const verifyTotpChallenge = jest.fn();
   const getSessionData = jest.fn();
@@ -14,7 +16,9 @@ describe('AuthController', () => {
   const authService = {
     createTokens,
     authenticateWithLocal,
+    getLocalBruteforceBlock,
     isTotpEnabledForUser,
+    hasWebAuthnKeyForUser,
     createMfaChallenge,
     verifyTotpChallenge,
     getSessionData,
@@ -37,6 +41,9 @@ describe('AuthController', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
+    getLocalBruteforceBlock.mockResolvedValue({ blocked: false, retryAfterSeconds: 0 });
+    hasWebAuthnKeyForUser.mockReturnValue(false);
+    isTotpEnabledForUser.mockReturnValue(false);
     controller = new AuthController({} as any, authService as any, rolesService as any);
   });
 

apps/api/tests/unit/core/auth/auth.service.spec.ts

@@ -12,11 +12,15 @@ describe('AuthService', () => {
   const redisSet = jest.fn();
   const redisExpire = jest.fn();
   const redisDel = jest.fn();
+  const redisTtl = jest.fn();
+  const redisIncr = jest.fn();
   const redis = {
     get: redisGet,
     set: redisSet,
     expire: redisExpire,
     del: redisDel,
+    ttl: redisTtl,
+    incr: redisIncr,
   };
 
   const agentsFindOne = jest.fn();
@@ -48,6 +52,8 @@ describe('AuthService', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
+    redisTtl.mockResolvedValue(-2);
+    redisIncr.mockResolvedValue(1);
     service = new AuthService(
       {} as any,
       agentsService as any,