Enigmatic Addons Causes Transfurs to Freeze

[Connor6576]

I found an issue between Enigmatic Addons and Changed. For some reason Enigmatic Addons causes some transfurs to freeze to death. I found this out by disabling mods until I found which one was causing the issue. I have a list of which one freeze. It includes some from Changed Addons Plus. I know it was made by someone else, but I had it on so why not add them to the list. I have no clue what would cause this. It also freezes you if you are any of the transfurs on the list.

Transfurs that take freeze damage.txt

Enigmatic Addons Link: https://www.curseforge.com/minecraft/mc-mods/enigmatic-addons

[LtxProgrammer]

enigmaticaddons.mixins.json:MixinEntity.java#L27-L41 is overriding the vanilla getTicksRequiredToFreeze() by adding some arbitrary amount of ticks: 400. The entities in the Changed mod override getTicksRequiredToFreeze() themselves to either give the player more time or less time available before freezing.

Vanilla + Changed:

• Default entity (and not-tf'd player): 140
• Changed wolf: 240

Vanilla + Changed + Enigmatic addons:

• Default entity (and not-tf'd player): 540
• Changed wolf: 240

Enigmatic addons is removing this 400 tick offset in calculations when checking if the entity is fully frozen. Ex:

// For player, this evaluates to false but will evaluate to true as expected.
boolean fullyFrozen = 0 /* ticksFrozen */ > 540 /* ticksRequiredToFreeze */ - 400;

// For tf'd player, this always evaluates to true because 0 is greater than a negative value
boolean fullyFrozen = 0 /* ticksFrozen */ > 240 /* ticksRequiredToFreeze */ - 400;

To my understanding, Enigmatic addons uses this 400 tick offset to allow certain mod features to apply freeze damage-over-time by extending the maximum freeze value by 10 seconds of decay. Their implementation has the side-effect of changing the behavior of vanilla freezing (being in powdered snow), by causing extended exposure in powdered snow to go over the vanilla cap of 140 ticks which makes unfreezing take longer.

I recommend that Enigmatic addons replace this mixin adding/removing the 400 tick capacity with a mixin that removes the effective cap in vanilla code by overriding this.setTicksFrozen(Math.min(this.getTicksRequiredToFreeze(), ticksFrozen + 1)); found in LivingEntity.aiStep(). This is the only place in vanilla code that puts a cap on ticksFrozen.

Writing a compatibility mixin into every Changed entity that overrides each getTicksRequiredToFreeze() is unrealistic and unsustainable.

[LtxProgrammer]

I should acknowledge, however, that other mods may also use getTicksRequiredToFreeze() as the cap on ticksFrozen. Tough As Nails is such a mod that does this.

[Connor6576]

I did remove the mod because I'm fine with not using it. I feel like not many people will find this issue anyway, but I'm glad I know why Enigmatic Addons causes that.