[BUG ?] One player can open vm

[hikinata]

Vending machines only open for one player at a time, if another player accesses it, it closes for the first one.

I don't know if this is a bug or intended. Is this patchable?

[Lupicus]

what version of minecraft are you using?
it should act like a villager, i.e. only one player at a time, but should ignore second player until first player is done.

[hikinata]

I'm in 1.20.1 and I better understand the fact that it simulates a villager, isn't it possible to allow several players at the same time?

But suddenly the close that players 2 close the menu when player 1 buys isn't it normal?

[Lupicus]

It is a simple fix for same behavior as villager (i.e. to block others from trading), since it is sharing that code and I'm missing a check in my code.
Allowing multiple players to trade would require more work (i.e. deviate from existing villager code), if it is possible.

[hikinata]

I understand, but I would have thought that if each player had his instance I didn't think it could generate too much work.

I use a mycmd plugin to create the menu, but I wanted to have a block to open it

[Lupicus]

The main problem is with the trades, when one person buys stuff then others will still see the same number of items available when they opened it, though I'm guessing that the server might not sell extras on the same trade. Also restocking could occur on second person opening the menu, so the 2 players could be seeing different set of trades and not sure what the first person would actually buy, since the server will have the new trades.

I would have to create several classes (menu and container), I believe, to prevent the closing, since that is part of the merchant logic. Then add logic to send trade updates to the other players when trades happen.