From 0c35c22da5a963183993a1ad096bd20441525724 Mon Sep 17 00:00:00 2001
From: shirazos7 <shiraz@zbmath.org>
Date: Mon, 3 Feb 2025 14:51:29 +0100
Subject: [PATCH 1/3] adjusting the mandatory properties

---
 xslt/articles/xslt-article-Datacite.xslt | 112 +++++++++++++++--------
 1 file changed, 76 insertions(+), 36 deletions(-)

diff --git a/xslt/articles/xslt-article-Datacite.xslt b/xslt/articles/xslt-article-Datacite.xslt
index 92b4f17f..2a53edb0 100644
--- a/xslt/articles/xslt-article-Datacite.xslt
+++ b/xslt/articles/xslt-article-Datacite.xslt
@@ -96,43 +96,83 @@ Content generated by zbMATH Open, such as reviews, classifications, software, or
     </xsl:template>
 
     <!-- Template for processing authors -->
-    <xsl:template match="authors">
-        <creator>
-            <creatorName nameType="Personal">
-                <xsl:value-of select="name"/>
-            </creatorName>
-            <givenName>
-                <xsl:value-of select="substring-before(name, ',')"/>
-            </givenName>
-            <familyName>
-                <xsl:value-of select="substring-after(name, ', ')"/>
-            </familyName>
-            <nameIdentifier schemeURI="https://zbmath.org/" nameIdentifierScheme="zbMATH Author Code">
-                <xsl:value-of select="codes"/>
-            </nameIdentifier>
-        </creator>
-    </xsl:template>
+   <xsl:template match="authors">
+    <creator>
+        <creatorName nameType="Personal">
+            <xsl:choose>
+                <xsl:when test="normalize-space(name) = '' or name = 'None' or name = 'none'">:unav</xsl:when>
+                <xsl:otherwise>
+                    <xsl:value-of select="name"/>
+                </xsl:otherwise>
+            </xsl:choose>
+        </creatorName>
+
+        <givenName>
+            <xsl:choose>
+                <xsl:when test="normalize-space(name) = '' or name = 'None' or name = 'none'">:unav</xsl:when>
+                <xsl:otherwise>
+                    <xsl:value-of select="substring-before(name, ',')"/>
+                </xsl:otherwise>
+            </xsl:choose>
+        </givenName>
+
+        <familyName>
+            <xsl:choose>
+                <xsl:when test="normalize-space(name) = '' or name = 'None' or name = 'none'">:unav</xsl:when>
+                <xsl:otherwise>
+                    <xsl:value-of select="substring-after(name, ', ')"/>
+                </xsl:otherwise>
+            </xsl:choose>
+        </familyName>
+
+        <nameIdentifier schemeURI="https://zbmath.org/" nameIdentifierScheme="zbMATH Author Code">
+            <xsl:choose>
+                <xsl:when test="normalize-space(codes) = '' or codes = 'None' or codes = 'none'">:unav</xsl:when>
+                <xsl:otherwise>
+                    <xsl:value-of select="codes"/>
+                </xsl:otherwise>
+            </xsl:choose>
+        </nameIdentifier>
+    </creator>
+</xsl:template>
+
     <!-- Template for processing titles -->
-        <xsl:template match="title">
-            <!-- Transform titles into structured titles -->
-        <titles>
-            <title xml:lang="en">
-                <xsl:value-of select="title"/>
-            </title>
-        </titles>
-           </xsl:template>
-     <!-- Template for processing publisher -->
-            <xsl:template match="publisher">
-            <publisher xml:lang="en">
-            <xsl:value-of select="."/>
-            </publisher>
-            </xsl:template>
-    <!-- Template for processing publication year -->
-          <xsl:template match="year">
-            <publicationYear>
-             <xsl:value-of select="."/>
-            </publicationYear>
-            </xsl:template>
+     <xsl:template match="title">
+    <titles>
+        <title xml:lang="en">
+            <xsl:choose>
+                <xsl:when test="normalize-space(.) = '' or . = 'None' or . = 'none'">:unkn</xsl:when>
+                <xsl:otherwise>
+                    <xsl:value-of select="."/>
+                </xsl:otherwise>
+            </xsl:choose>
+        </title>
+    </titles>
+</xsl:template>
+
+<xsl:template match="publisher">
+    <publisher xml:lang="en">
+        <xsl:choose>
+            <xsl:when test="normalize-space(.) = '' or . = 'None' or . = 'none'">:unav</xsl:when>
+            <xsl:otherwise>
+                <xsl:value-of select="."/>
+            </xsl:otherwise>
+        </xsl:choose>
+    </publisher>
+</xsl:template>
+
+<xsl:template match="year">
+    <publicationYear>
+        <xsl:choose>
+            <xsl:when test="normalize-space(.) = '' or . = 'None' or . = 'none'">:unav</xsl:when>
+            <xsl:otherwise>
+                <xsl:value-of select="."/>
+            </xsl:otherwise>
+        </xsl:choose>
+    </publicationYear>
+</xsl:template>
+
+
     <!-- Template for processing the language of the document -->
       <xsl:template match="languages">
            <xsl:if test="normalize-space(.) != '' and . != 'None'and . != 'none'">

From 5b511855323281cc098a28214e07ef5c4a03d5f8 Mon Sep 17 00:00:00 2001
From: shirazos7 <shiraz@zbmath.org>
Date: Tue, 4 Feb 2025 12:02:00 +0100
Subject: [PATCH 2/3] adjusting the templates title and creator

---
 xslt/articles/xslt-article-Datacite.xslt | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/xslt/articles/xslt-article-Datacite.xslt b/xslt/articles/xslt-article-Datacite.xslt
index 2a53edb0..a6a49016 100644
--- a/xslt/articles/xslt-article-Datacite.xslt
+++ b/xslt/articles/xslt-article-Datacite.xslt
@@ -96,13 +96,13 @@ Content generated by zbMATH Open, such as reviews, classifications, software, or
     </xsl:template>
 
     <!-- Template for processing authors -->
-   <xsl:template match="authors">
+  <xsl:template match="authors">
     <creator>
         <creatorName nameType="Personal">
             <xsl:choose>
                 <xsl:when test="normalize-space(name) = '' or name = 'None' or name = 'none'">:unav</xsl:when>
                 <xsl:otherwise>
-                    <xsl:value-of select="name"/>
+                    <xsl:value-of select="normalize-space(name)"/>
                 </xsl:otherwise>
             </xsl:choose>
         </creatorName>
@@ -111,7 +111,7 @@ Content generated by zbMATH Open, such as reviews, classifications, software, or
             <xsl:choose>
                 <xsl:when test="normalize-space(name) = '' or name = 'None' or name = 'none'">:unav</xsl:when>
                 <xsl:otherwise>
-                    <xsl:value-of select="substring-before(name, ',')"/>
+                    <xsl:value-of select="normalize-space(substring-before(name, ','))"/>
                 </xsl:otherwise>
             </xsl:choose>
         </givenName>
@@ -120,7 +120,7 @@ Content generated by zbMATH Open, such as reviews, classifications, software, or
             <xsl:choose>
                 <xsl:when test="normalize-space(name) = '' or name = 'None' or name = 'none'">:unav</xsl:when>
                 <xsl:otherwise>
-                    <xsl:value-of select="substring-after(name, ', ')"/>
+                    <xsl:value-of select="normalize-space(substring-after(name, ', '))"/>
                 </xsl:otherwise>
             </xsl:choose>
         </familyName>
@@ -129,27 +129,29 @@ Content generated by zbMATH Open, such as reviews, classifications, software, or
             <xsl:choose>
                 <xsl:when test="normalize-space(codes) = '' or codes = 'None' or codes = 'none'">:unav</xsl:when>
                 <xsl:otherwise>
-                    <xsl:value-of select="codes"/>
+                    <xsl:value-of select="normalize-space(codes)"/>
                 </xsl:otherwise>
             </xsl:choose>
         </nameIdentifier>
     </creator>
 </xsl:template>
 
+
     <!-- Template for processing titles -->
-     <xsl:template match="title">
+    <xsl:template match="title">
     <titles>
         <title xml:lang="en">
             <xsl:choose>
                 <xsl:when test="normalize-space(.) = '' or . = 'None' or . = 'none'">:unkn</xsl:when>
                 <xsl:otherwise>
-                    <xsl:value-of select="."/>
+                    <xsl:value-of select="normalize-space(.)"/>
                 </xsl:otherwise>
             </xsl:choose>
         </title>
     </titles>
 </xsl:template>
 
+
 <xsl:template match="publisher">
     <publisher xml:lang="en">
         <xsl:choose>

From f0d69190f780cb96beb16e27249065f249ee2c2a Mon Sep 17 00:00:00 2001
From: shirazos7 <shiraz@zbmath.org>
Date: Tue, 4 Feb 2025 12:04:04 +0100
Subject: [PATCH 3/3] removing the print statements from the code

---
 test/test_metadata_article_Datacite.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/test_metadata_article_Datacite.py b/test/test_metadata_article_Datacite.py
index 2dcdf9b7..5d6583b2 100644
--- a/test/test_metadata_article_Datacite.py
+++ b/test/test_metadata_article_Datacite.py
@@ -33,11 +33,11 @@ def test_similarity(self):
 
         transform = ET.XSLT(xslt)  # is it a reserved word
         newdom = transform(dom)
-        print(newdom)
+
         real_string = ET.tostring(newdom, pretty_print=True, encoding='utf8').decode()
         # test if result is parsable
         reference = ET.parse(r'test/data/articles/Test_Reference-Datacite.xml')
-        print(reference)
+
         expected_string = ET.tostring(reference, pretty_print=True, encoding='utf8').decode()
         diff = main.diff_texts(expected_string, real_string, {
             'ratio_mode': 'fast',  # is that for latency