[BUG] Lock View settings not rendering in scene configuration window (Foundryborne/Daggerheart)

[greedyj4ck]

Setup

• OS: Windows 11
• Browser: Foundry App
• Module version: 2.0.2
• Foundry version: 13.351]
• Gaming system & version: Foundryborne/Daggerheart 1.7.0
• Any other modules enabled: No

Describe the bug
Lock View settings are not being rendered in scene settings window. Other functionality still works (scene configurator / using toolbar buttons).

Screenshots

Console Log

overrides.js:194 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'addEventListener')
[Detected 2 packages: LockView(2.0.2), lib-wrapper(1.13.4.0)]
at 🎁foundry.applications.sheets.SceneConfig.prototype._onRender#LockView (overrides.js:194:72)
at 🎁call_wrapper [as call_wrapper] (libWrapper-wrapper.js:639:16)
at 🎁foundry.applications.sheets.SceneConfig.prototype._onRender#0 (libWrapper-wrapper.js:193:20)
at DhSceneConfigSettings._doEvent (foundry.mjs:27926:30)
at #render (foundry.mjs:27263:16)
at async #try (foundry.mjs:7169:17)

Additional context
Issue is related to Daggerheart system. Probably due to system utilizing custom Scene Configuration Settings object.

[farling42]

This is possibly due to Lock View expecting to override the base SceneConfig class, which won't work alongside any game system which uses their subclass of SceneConfig.

The module generates a similar error with the Torg Eternity game system which uses their own SceneConfig class.

[MaterialFoundry]

This is possibly due to Lock View expecting to override the base SceneConfig class, which won't work alongside any game system which uses their subclass of SceneConfig.

I think you're right, here's what (I believe) happens:

1. Lock View adds the Lock View tab to the Scene Config
2. Daggerheart replaces the Scene Config with its own implementation
3. When the Scene Config is opened, Lock View tries to do it's thing, but throws an error because the Daggerheart Scene Config has thrown out the Lock View tab contents

I think I've found a fix by waiting until the ready hook (so systems have the time to register their own sheet), and then modifying the active Scene Config, instead of the default Foundry one. This appears to work (tried it in Daggerheart and dnd5e), but please let me know if you run into any issues.

I'm not pushing this as a full release yet, because I'm not yet convinced that this can't cause issues elsewhere, but you can install it using this manifest url: https://github.com/MaterialFoundry/LockView/releases/download/v2.0.3_pre2/module.json

[greedyj4ck]

Gonna test it and get back with feedback :) Thanks!

[farling42]

The setting of sceneConfig has a wrong assumption about index 0:

let sceneConfig = Object.values(CONFIG.Scene.sheetClasses.base)[0].cls;

The following should work for most systems (and does work for TorgEternity, which hasn't removed the default sheet):

let sceneConfig = Object.values(CONFIG.Scene.sheetClasses.base).find(sheet => sheet.default).cls;