Skip to content

feat(extension): rework merge-box queue row to match GitHub native styling#475

Open
jd wants to merge 1 commit into
mainfrom
devs/jd/worktree-background/rework-merge-box-queue-row-match-github-native--41e4c5e0
Open

feat(extension): rework merge-box queue row to match GitHub native styling#475
jd wants to merge 1 commit into
mainfrom
devs/jd/worktree-background/rework-merge-box-queue-row-match-github-native--41e4c5e0

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 20, 2026

Reuse Primer utility classes (bgColor-muted, borderColor-muted, border-top,
rounded-bottom-2) and the --base-size-16 padding token, so the Mergify row
sits flush against GH's own "Merge pull request" section in the merge box
instead of inheriting the darker page bg with an ad-hoc border-top.

Restructure the row so it reads like a GH action panel:

[Add to merge queue] [Refresh] [Rebase] [Update] ☰ queue 🕓 logs [● Mergify]

  • All action buttons grouped on the left (matches GH's "Squash and merge"
    • chevron block).
  • Right cluster holds the navigation: queue/logs links with Octicon
    prefixes (list-unordered for queue, clock for logs) so they read as
    first-class nav rather than metadata, and the logo+Mergify text fused
    into one anchor linking to dashboard.mergify.com.
  • Primary/dequeue labels expanded ("Add to merge queue" / "Remove from
    merge queue") so the primary button has the same visual weight as
    GitHub's merge button and clearly states what it does.
  • 24px effective left padding so the primary button doesn't crowd the
    card edge.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Copilot AI review requested due to automatic review settings May 20, 2026 10:07
@jd
Copy link
Copy Markdown
Member Author

jd commented May 20, 2026

This pull request is part of a Mergify stack:

# Pull Request Link
1 feat(extension): rework merge-box queue row to match GitHub native styling #475 👈
2 perf(extension): inject Mergify merge-box row before network state arrives #476

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 20, 2026 10:07 Failure
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 20, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Required Reviews

Waiting for

  • #approved-reviews-by >= 2
This rule is failing.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reworks the merge-box “Mergify” queue row UI to better match GitHub’s native merge panel styling and layout by adopting Primer utility classes/tokens and restructuring the row into left-aligned actions with right-aligned navigation/branding.

Changes:

  • Updates queue button copy to clearer, GitHub-like phrasing (“Add/Remove from merge queue”, expanded pending labels).
  • Refactors buildMergifyRow() layout: action buttons grouped on the left; queue/logs links and Mergify brand link grouped on the right with icons.
  • Uses Primer utility classes and the --base-size-16 padding token to blend with GitHub’s merge box styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/queue.js Outdated
Comment thread src/queue.js
Comment thread src/queue.js
Comment thread src/queue.js Outdated
@jd jd marked this pull request as ready for review May 20, 2026 10:12
…yling

Reuse Primer utility classes (bgColor-muted, borderColor-muted, border-top,
rounded-bottom-2) and the --base-size-16 padding token, so the Mergify row
sits flush against GH's own "Merge pull request" section in the merge box
instead of inheriting the darker page bg with an ad-hoc border-top.

Restructure the row so it reads like a GH action panel:

  [Add to merge queue] [Refresh] [Rebase] [Update]   ☰ queue   🕓 logs   [● Mergify]

- All action buttons grouped on the left (matches GH's "Squash and merge"
  + chevron block).
- Right cluster holds the navigation: queue/logs links with Octicon
  prefixes (list-unordered for queue, clock for logs) so they read as
  first-class nav rather than metadata, and the logo+Mergify text fused
  into one anchor linking to dashboard.mergify.com.
- Primary/dequeue labels expanded ("Add to merge queue" / "Remove from
  merge queue") so the primary button has the same visual weight as
  GitHub's merge button and clearly states what it does.
- 24px effective left padding so the primary button doesn't crowd the
  card edge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Change-Id: I41e4c5e0a527bea4915e4bff37b04402a58f8fe6
@jd jd force-pushed the devs/jd/worktree-background/rework-merge-box-queue-row-match-github-native--41e4c5e0 branch from 19fe4d1 to 6f316fa Compare May 20, 2026 10:14
@jd
Copy link
Copy Markdown
Member Author

jd commented May 20, 2026

Revision history

# Type Changes Reason Date
1 initial 19fe4d1 2026-05-20 10:15 UTC
2 content 19fe4d1 → 6f316fa (raw) address review #475: drop export on QUEUE_ICON_SVG/LOGS_ICON_SVG (Copilot gc6DcMgl), mark decorative SVGs as aria-hidden/focusable=false (Copilot gc6DcMhT), break long ternary across multiple lines t… 2026-05-20 10:15 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 20, 2026 10:15 Failure
@jd jd requested a review from a team May 21, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants