perf(extension): inject Mergify merge-box row before network state arrives#476
Conversation
Member
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of
🔴 Required ReviewsWaiting for
This rule is failing.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
…rives
Previously the row was the very last thing to appear in the merge box on
cold loads — the user would see GitHub's "Squash and merge" panel for
seconds before the Mergify "Add to merge queue" button materialised.
The reason is that `_tryInject` awaited four network roundtrips in
sequence before building the row:
1. `/search?q=…mergify.yml` (is Mergify enabled on this repo?)
2. fetchCommentBodies (stack/revision context)
3. `/{org}/{repo}/pull/{n}/checks` (find the queue check-run ID)
4. `/{org}/{repo}/runs/{check_run_id}` (resolve "queued" vs "evaluating")
Reorder so the row appears as soon as the merge box exists:
- The is-Mergify-enabled check now tries the synchronous detection path
first (Mergify app-icon in the DOM or a cached repo result). The
`/search` fetch is only paid on the rare cold load where Mergify has
not yet commented on the page.
- The initial row is built with state derived synchronously from the
DOM (`deriveQueueButtonState` reads open/merged/closed, the expanded
Checks section if present, and the last `@mergifyio` command — all
sync), then injected immediately into the merge box.
- `renderMergifyContext` and `fetchQueueStateIfNeeded` now run in
parallel as background fire-and-forgets. When the queue-state fetch
resolves, a `then()` callback runs `updateMergifyRow`, which swaps
the button in place if its `data-mergify-queue-btn` attribute
changed — no full row rebuild.
- The merge-box DOM-walking is extracted into `injectRowIntoMergeBox()`
to keep the new early-injection path readable.
Trade-off: on a PR that *is* queued, when the Checks section has not
been expanded, the button briefly shows "Add to merge queue" before
flipping to "Remove from merge queue" once the network state arrives.
This is a single-button swap, not a row reflow.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Change-Id: Iaab5480cfb96d04421bd4136576620f2487c4780
e57f72e to
053c047
Compare
19fe4d1 to
6f316fa
Compare
Member
Author
Revision history
|
sileht
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the row was the very last thing to appear in the merge box on
cold loads — the user would see GitHub's "Squash and merge" panel for
seconds before the Mergify "Add to merge queue" button materialised.
The reason is that
_tryInjectawaited four network roundtrips insequence before building the row:
/search?q=…mergify.yml(is Mergify enabled on this repo?)/{org}/{repo}/pull/{n}/checks(find the queue check-run ID)/{org}/{repo}/runs/{check_run_id}(resolve "queued" vs "evaluating")Reorder so the row appears as soon as the merge box exists:
first (Mergify app-icon in the DOM or a cached repo result). The
/searchfetch is only paid on the rare cold load where Mergify hasnot yet commented on the page.
DOM (
deriveQueueButtonStatereads open/merged/closed, the expandedChecks section if present, and the last
@mergifyiocommand — allsync), then injected immediately into the merge box.
renderMergifyContextandfetchQueueStateIfNeedednow run inparallel as background fire-and-forgets. When the queue-state fetch
resolves, a
then()callback runsupdateMergifyRow, which swapsthe button in place if its
data-mergify-queue-btnattributechanged — no full row rebuild.
injectRowIntoMergeBox()to keep the new early-injection path readable.
Trade-off: on a PR that is queued, when the Checks section has not
been expanded, the button briefly shows "Add to merge queue" before
flipping to "Remove from merge queue" once the network state arrives.
This is a single-button swap, not a row reflow.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Depends-On: #475