Skip to content

Make the TripPin.Feed type change more clear#522

Open
brandonstubbs wants to merge 2 commits into
MicrosoftDocs:mainfrom
brandonstubbs:patch-1
Open

Make the TripPin.Feed type change more clear#522
brandonstubbs wants to merge 2 commits into
MicrosoftDocs:mainfrom
brandonstubbs:patch-1

Conversation

@brandonstubbs

@brandonstubbs brandonstubbs commented Mar 20, 2024

Copy link
Copy Markdown

I missed the step of updating the connector code to change the schema parameter and it took a while to figure out why all my unit tests were coming back as null except for the Check that we have three entries in our nav table test. It might be better to explicitly show this step. LMKWYT

@prmerger-automator prmerger-automator Bot added the do-not-merge Don't merge this yet label Mar 20, 2024
@prmerger-automator

Copy link
Copy Markdown
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 8eccc7d:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/samples/trippin/7-advancedschema/readme.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator

Copy link
Copy Markdown
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72

Court72 commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

@DougKlopfenstein

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@JasonWHowell JasonWHowell added the needs-engineering-review Discussing with Microsoft's engineering team. label May 28, 2024
@ktoliver

ktoliver commented Nov 3, 2025

Copy link
Copy Markdown

@JasonWHowell @ptyx507x - Is this proposed update still slated for engineering review?

@JasonWHowell

Copy link
Copy Markdown
Collaborator

@ktoliver I'm not on this team any longer. @DougKlopfenstein is the writer on Kate's team.

@ktoliver

ktoliver commented Nov 3, 2025

Copy link
Copy Markdown

@ktoliver I'm not on this team any longer. @DougKlopfenstein is the writer on Kate's team.

OK, thanks @JasonWHowell

@prmerger-automator

Copy link
Copy Markdown
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 8fce3ac:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/samples/trippin/7-advancedschema/readme.md ✅Succeeded

For more details, please refer to the build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aq-pr-triaged Change sent to author do-not-merge Don't merge this yet needs-engineering-review Discussing with Microsoft's engineering team. powerquery/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants