[JitDiff X64] [tannergooding] Generalize IsBitwiseEquatable to field-wise IE ...

[MihuBot]

Job completed in 23 minutes 5 seconds (remote runner delay: 1 minute 11 seconds).
dotnet/runtime#130723
Using arguments: -nuget
Main commit: dotnet/runtime@1f4ca7e
PR commit: tannergooding/runtime@0f7aa7e

Diffs

Found 109 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 395588295
Total bytes of diff: 395588292
Total bytes of delta: -3 (-0.00 % of base)
Total relative delta: -0.02
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
          -3 : NLog.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 759 unchanged.

Top method improvements (bytes):
          -3 (-2.05 % of base) : NLog.dasm - NLog.LayoutRenderers.GuidLayoutRenderer:GetValue(NLog.LogEventInfo):System.Guid:this (FullOpts)

Top method improvements (percentages):
          -3 (-2.05 % of base) : NLog.dasm - NLog.LayoutRenderers.GuidLayoutRenderer:GetValue(NLog.LogEventInfo):System.Guid:this (FullOpts)

1 total methods with Code Size differences (1 improved, 0 regressed), 2114430 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• PackageList.json (200 KB)
• diff-frameworks.txt (969 B)
• ShortDiffsImprovements.md (4 KB)
• jit-diffs-main.7z (381 MB)
• jit-diffs-pr.7z (382 MB)

[MihuBot]

Top method improvements

-3 (-2.05 % of base) - NLog.LayoutRenderers.GuidLayoutRenderer:GetValue(NLog.LogEventInfo):System.Guid:this

 ; Assembly listing for method NLog.LayoutRenderers.GuidLayoutRenderer:GetValue(NLog.LogEventInfo):System.Guid:this (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; 0 inlinees with PGO data; 3 single block inlinees; 0 inlinees without PGO data
 ; Final local variable assignments
 ;
 ;  V00 this         [V00,T01] (  3,  3   )     ref  ->  rdi         this class-hnd single-def <NLog.LayoutRenderers.GuidLayoutRenderer>
 ;  V01 arg1         [V01,T00] (  5,  3.50)     ref  ->  rbx         class-hnd single-def <NLog.LogEventInfo>
-;  V02 loc0         [V02,T02] (  8,  4.50)  struct (16) [rbp-0x28]  do-not-enreg[SFRM] multireg-ret multireg-dest must-init ld-addr-op <System.Guid>
+;  V02 loc0         [V02,T02] (  6,  3.50)  struct (16) [rbp-0x28]  do-not-enreg[SFRM] multireg-ret multireg-dest must-init ld-addr-op <System.Guid>
 ;  V03 loc1         [V03,T04] (  2,  1   )   short  ->  r15         single-def
 ;  V04 loc2         [V04,T05] (  2,  1   )   short  ->  r14         single-def
 ;* V05 loc3         [V05,T07] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V06 loc4         [V06,T08] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V07 loc5         [V07,T09] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V08 loc6         [V08,T10] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V09 loc7         [V09,T11] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V10 loc8         [V10,T12] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V11 loc9         [V11,T13] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;* V12 loc10        [V12,T14] (  0,  0   )   ubyte  ->  zero-ref    single-def
 ;# V13 OutArgs      [V13    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;  V14 tmp1         [V14,T03] (  3,  3   )     int  ->  rax         "dup spill"
 ;* V15 tmp2         [V15,T06] (  0,  0   )    long  ->  zero-ref    "dup spill"
 ;* V16 tmp3         [V16    ] (  0,  0   )     int  ->  zero-ref    "Inlining Arg"
 ;
 ; Lcl frame size = 24
 
 G_M63018_IG01:
        push     rbp
        push     r15
        push     r14
        push     rbx
        sub      rsp, 24
        lea      rbp, [rsp+0x30]
        xor      eax, eax
        mov      qword ptr [rbp-0x28], rax
        mov      qword ptr [rbp-0x20], rax
        mov      rbx, rsi
 						;; size=28 bbWeight=1 PerfScore 7.25
 G_M63018_IG02:
        cmp      byte  ptr [rdi+0x19], 0
        jne      SHORT G_M63018_IG04
 						;; size=6 bbWeight=1 PerfScore 3.00
 G_M63018_IG03:
        mov      rax, 0xD1FFAB1E      ; code for System.Guid:NewGuid():System.Guid
        call     [rax]System.Guid:NewGuid():System.Guid
        mov      qword ptr [rbp-0x28], rax
        mov      qword ptr [rbp-0x20], rdx
        jmp      SHORT G_M63018_IG05
 						;; size=22 bbWeight=0.50 PerfScore 3.62
 G_M63018_IG04:
        mov      rdi, rbx
        mov      rax, qword ptr [rbx]
        mov      rax, qword ptr [rax+0x40]
        call     [rax+0x18]System.Object:GetHashCode():int:this
        mov      edi, eax
        sar      edi, 16
        movsx    r15, di
        movsx    r14, ax
        mov      rdi, rbx
        mov      rax, 0xD1FFAB1E      ; code for NLog.LogEventInfo:get_SequenceID():int:this
        call     [rax]NLog.LogEventInfo:get_SequenceID():int:this
        mov      dword ptr [rbp-0x28], eax
        mov      word  ptr [rbp-0x24], r15w
        mov      word  ptr [rbp-0x22], r14w
-       mov      dword ptr [rbp-0x20], 0xD1FFAB1E
-       mov      word  ptr [rbp-0x1C], 0x15D4
-       mov      byte  ptr [rbp-0x19], 119
-						;; size=71 bbWeight=0.50 PerfScore 9.00
+       mov      rax, 0xD1FFAB1E
+       mov      qword ptr [rbp-0x20], rax
+						;; size=68 bbWeight=0.50 PerfScore 8.12
 G_M63018_IG05:
        mov      rax, qword ptr [rbp-0x28]
        mov      rdx, qword ptr [rbp-0x20]
 						;; size=8 bbWeight=1 PerfScore 2.00
 G_M63018_IG06:
        add      rsp, 24
        pop      rbx
        pop      r14
        pop      r15
        pop      rbp
        ret      
 						;; size=11 bbWeight=1 PerfScore 3.25
 
-; Total bytes of code 146, prolog size 25, PerfScore 28.12, instruction count 42, allocated bytes for code 146 (MethodHash=e1f609d5) for method NLog.LayoutRenderers.GuidLayoutRenderer:GetValue(NLog.LogEventInfo):System.Guid:this (FullOpts)
+; Total bytes of code 143, prolog size 25, PerfScore 27.25, instruction count 41, allocated bytes for code 143 (MethodHash=e1f609d5) for method NLog.LayoutRenderers.GuidLayoutRenderer:GetValue(NLog.LogEventInfo):System.Guid:this (FullOpts)
 ; ============================================================

[MihuBot]

@tannergooding