Skip to content

[JitDiff X64] [EgorBo] Remove redundant pinning over static fields/RVA #2093

Description

@MihuBot

Job completed in 24 minutes 6 seconds (remote runner delay: 1 minute 12 seconds).
dotnet/runtime#119674
Using arguments: -nuget
Main commit: dotnet/runtime@6e0eb83
PR commit: EgorBo/runtime-1@9ae9de7

Diffs

Diffs
Found 113 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 395612743
Total bytes of diff: 395611483
Total bytes of delta: -1260 (-0.00 % of base)
Total relative delta: -3.25
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
        -717 : System.Private.CoreLib.dasm (-0.01 % of base)
        -109 : System.Private.DataContractSerialization.dasm (-0.01 % of base)
         -93 : SkiaSharp.dasm (-0.01 % of base)
         -76 : SixLabors.ImageSharp.dasm (-0.00 % of base)
         -66 : System.Net.Sockets.dasm (-0.02 % of base)
         -64 : System.IO.Hashing.dasm (-0.17 % of base)
         -50 : Microsoft.CodeAnalysis.AnalyzerUtilities.dasm (-0.00 % of base)
         -44 : System.Console.dasm (-0.05 % of base)
         -25 : System.Net.Quic.dasm (-0.02 % of base)
         -16 : SharpCompress.dasm (-0.00 % of base)

10 total files with Code Size differences (10 improved, 0 regressed), 750 unchanged.

Top method improvements (bytes):
         -93 (-23.02 % of base) : SkiaSharp.dasm - SkiaSharp.SKImageInfo:.cctor() (FullOpts)
         -84 (-10.81 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:DetermineIdentityAndInner(nint,nint,int,byref,byref,byref) (FullOpts)
         -66 (-47.48 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.UnixDomainSocketEndPoint:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[byte]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[double]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[int]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[long]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[short]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[System.Nullable`1[int]]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[System.Numerics.Vector`1[float]]:.cctor() (FullOpts)
         -54 (-8.49 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ReferenceTrackerHost:IReferenceTrackerHost_GetTrackerTarget(nint,nint,ptr):int (FullOpts)
         -44 (-2.06 % of base) : System.Console.dasm - System.ConsolePal:EnsureInitializedCore() (FullOpts) (2 methods)
         -40 (-6.21 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:ComWeakRefToObject(nint,System.Object):System.Object (FullOpts)
         -38 (-8.54 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper:Create(nint,nint,System.Runtime.InteropServices.ComWrappers,System.Object,int,byref):System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper (FullOpts)
         -36 (-36.00 % of base) : Microsoft.CodeAnalysis.AnalyzerUtilities.dasm - System.IO.Hashing.XxHashShared:DeriveSecretFromSeed(ptr,ulong) (FullOpts)
         -36 (-31.58 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHashShared:DeriveSecretFromSeed(ptr,ulong) (FullOpts)
         -35 (-10.74 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInstance(System.Object,byref):bool (FullOpts)
         -30 (-6.77 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Formats.Jpeg.Components.ZigZag:ApplyTransposingZigZagOrderingAvx2(byref) (FullOpts)
         -30 (-4.30 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Formats.Jpeg.Components.ZigZag:ApplyTransposingZigZagOrderingVector128(byref) (FullOpts)
         -27 (-2.10 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeParse(ptr,int):this (FullOpts)
         -26 (-5.83 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInterfaceDispatch(nint):ptr (FullOpts)
         -25 (-4.86 % of base) : System.Net.Quic.dasm - System.Net.Quic.MsQuicApi:.ctor(ptr):this (FullOpts)
         -24 (-2.14 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetChars(byte[],int,int,byte[],int):int:this (FullOpts)
         -20 (-10.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.RuntimeEventSourceHelper:GetCpuUsage():double (FullOpts)
         -20 (-1.42 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetBytes(byte[],int,int,byte[],int):int:this (FullOpts)
         -20 (-1.37 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetBytes(char[],int,int,byte[],int):int:this (FullOpts)
         -18 (-1.71 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetByteCount(char[],int,int):int:this (FullOpts)
         -16 (-4.16 % of base) : SharpCompress.dasm - SharpCompress.Algorithms.Adler32:CalculateSse(uint,System.ReadOnlySpan`1[byte]):uint (FullOpts)
         -16 (-4.16 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Compression.Zlib.Adler32:CalculateSse(uint,System.ReadOnlySpan`1[byte]):uint (FullOpts)
         -14 (-3.66 % of base) : Microsoft.CodeAnalysis.AnalyzerUtilities.dasm - System.IO.Hashing.XxHash128:HashLengthOver240(ptr,uint,ulong):System.IO.Hashing.XxHash128+Hash128 (FullOpts)
         -14 (-5.22 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash128:HashLengthOver240(ptr,uint,ulong):System.IO.Hashing.XxHash128+Hash128 (FullOpts)
         -14 (-6.33 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash3:HashLengthOver240(ptr,uint,ulong):ulong (FullOpts)

Top method improvements (percentages):
         -66 (-47.48 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.UnixDomainSocketEndPoint:.cctor() (FullOpts)
         -36 (-36.00 % of base) : Microsoft.CodeAnalysis.AnalyzerUtilities.dasm - System.IO.Hashing.XxHashShared:DeriveSecretFromSeed(ptr,ulong) (FullOpts)
         -36 (-31.58 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHashShared:DeriveSecretFromSeed(ptr,ulong) (FullOpts)
         -93 (-23.02 % of base) : SkiaSharp.dasm - SkiaSharp.SKImageInfo:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[byte]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[double]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[int]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[long]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[short]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[System.Nullable`1[int]]:.cctor() (FullOpts)
         -60 (-10.83 % of base) : System.Private.CoreLib.dasm - System.StubHelpers.LayoutClassMarshaler`1+Methods[System.Numerics.Vector`1[float]]:.cctor() (FullOpts)
         -84 (-10.81 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:DetermineIdentityAndInner(nint,nint,int,byref,byref,byref) (FullOpts)
         -35 (-10.74 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInstance(System.Object,byref):bool (FullOpts)
         -20 (-10.58 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.RuntimeEventSourceHelper:GetCpuUsage():double (FullOpts)
         -38 (-8.54 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper:Create(nint,nint,System.Runtime.InteropServices.ComWrappers,System.Object,int,byref):System.Runtime.InteropServices.ComWrappers+NativeObjectWrapper (FullOpts)
         -54 (-8.49 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ReferenceTrackerHost:IReferenceTrackerHost_GetTrackerTarget(nint,nint,ptr):int (FullOpts)
         -30 (-6.77 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Formats.Jpeg.Components.ZigZag:ApplyTransposingZigZagOrderingAvx2(byref) (FullOpts)
         -14 (-6.33 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash3:HashLengthOver240(ptr,uint,ulong):ulong (FullOpts)
         -40 (-6.21 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:ComWeakRefToObject(nint,System.Object):System.Object (FullOpts)
         -26 (-5.83 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.ComWrappers:TryGetComInterfaceDispatch(nint):ptr (FullOpts)
         -14 (-5.22 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.XxHash128:HashLengthOver240(ptr,uint,ulong):System.IO.Hashing.XxHash128+Hash128 (FullOpts)
         -25 (-4.86 % of base) : System.Net.Quic.dasm - System.Net.Quic.MsQuicApi:.ctor(ptr):this (FullOpts)
         -30 (-4.30 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Formats.Jpeg.Components.ZigZag:ApplyTransposingZigZagOrderingVector128(byref) (FullOpts)
         -16 (-4.16 % of base) : SharpCompress.dasm - SharpCompress.Algorithms.Adler32:CalculateSse(uint,System.ReadOnlySpan`1[byte]):uint (FullOpts)
         -16 (-4.16 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Compression.Zlib.Adler32:CalculateSse(uint,System.ReadOnlySpan`1[byte]):uint (FullOpts)
         -14 (-3.66 % of base) : Microsoft.CodeAnalysis.AnalyzerUtilities.dasm - System.IO.Hashing.XxHash128:HashLengthOver240(ptr,uint,ulong):System.IO.Hashing.XxHash128+Hash128 (FullOpts)
         -24 (-2.14 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetChars(byte[],int,int,byte[],int):int:this (FullOpts)
         -27 (-2.10 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeParse(ptr,int):this (FullOpts)
         -44 (-2.06 % of base) : System.Console.dasm - System.ConsolePal:EnsureInitializedCore() (FullOpts) (2 methods)
         -18 (-1.71 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetByteCount(char[],int,int):int:this (FullOpts)
         -20 (-1.42 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetBytes(byte[],int,int,byte[],int):int:this (FullOpts)
         -20 (-1.37 % of base) : System.Private.DataContractSerialization.dasm - System.Text.Base64Encoding:GetBytes(char[],int,int,byte[],int):int:this (FullOpts)

32 total methods with Code Size differences (32 improved, 0 regressed), 2114517 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions