Skip to content

[JitDiff X64] [MichalPetryka] Cleanup multicast delegate handling #2096

Description

@MihuBot

Job completed in 23 minutes 10 seconds (remote runner delay: 1 minute 15 seconds).
dotnet/runtime#130905
Using arguments: -nuget
Main commit: dotnet/runtime@11de6b6
PR commit: MichalPetryka/runtime@9ac2c45

Diffs

Found 109 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 395657482
Total bytes of diff: 395656829
Total bytes of delta: -653 (-0.00 % of base)
Total relative delta: 0.22
    diff is an improvement.
    relative diff is a regression.


Total byte diff includes -386 bytes from reconciling methods
	Base had    4 unique methods,     1076 unique bytes
	Diff had    7 unique methods,      690 unique bytes

Top file improvements (bytes):
        -653 : System.Private.CoreLib.dasm (-0.01 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 759 unchanged.

Top method regressions (bytes):
         311 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate:DeleteFromInvocationList(System.ReadOnlySpan`1[System.Delegate+Wrapper],int,int):System.Delegate+Wrapper[] (FullOpts) (0 base, 1 diff methods)
         200 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate:NewMulticastDelegate(System.Delegate+Wrapper[],int,bool):System.Delegate:this (FullOpts) (0 base, 1 diff methods)
          85 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate:TrySetSlot(byref,System.Delegate):bool (FullOpts) (0 base, 1 diff methods)
          68 (7.25 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:InvokeResolveEvent(System.ResolveEventHandler,System.Reflection.RuntimeAssembly,System.String):System.Reflection.RuntimeAssembly (FullOpts)
          63 (39.37 % of base) : System.Private.CoreLib.dasm - System.AppContext:OnFirstChanceException(System.Exception,System.Object) (FullOpts)
          63 (39.62 % of base) : System.Private.CoreLib.dasm - System.AppContext:OnUnhandledException(System.Object) (FullOpts)
          58 (59.18 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetResolvedUnmanagedDll(System.Reflection.Assembly,System.String):nint:this (FullOpts)
          51 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:Equals(System.Object):bool:this (FullOpts) (0 base, 1 diff methods)
          18 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:Equals(System.Delegate+Wrapper):bool:this (FullOpts) (0 base, 1 diff methods)
          18 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:GetHashCode():int:this (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:.ctor(System.Delegate):this (FullOpts) (0 base, 1 diff methods)

Top method improvements (bytes):
        -441 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:DeleteFromInvocationList(System.Object[],int,int,int):System.Object[]:this (FullOpts) (1 base, 0 diff methods)
        -258 (-19.91 % of base) : System.Private.CoreLib.dasm - System.Delegate:CombineImpl(System.Delegate):System.Delegate:this (FullOpts)
        -243 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:TrySetSlot(System.Object[],int,System.Object):bool (FullOpts) (1 base, 0 diff methods)
        -200 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:NewMulticastDelegate(System.Object[],int,bool):System.Delegate:this (FullOpts) (1 base, 0 diff methods)
        -192 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:EqualInvocationLists(System.Object[],System.Object[],int,int):bool (FullOpts) (1 base, 0 diff methods)
         -93 (-12.20 % of base) : System.Private.CoreLib.dasm - System.Delegate:RemoveImpl(System.Delegate):System.Delegate:this (FullOpts)
         -54 (-18.82 % of base) : System.Private.CoreLib.dasm - System.Delegate:GetInvocationList():System.Delegate[]:this (FullOpts)
         -27 (-23.28 % of base) : System.Private.CoreLib.dasm - System.Delegate:get_Target():System.Object:this (FullOpts)
         -25 (-8.93 % of base) : System.Private.CoreLib.dasm - System.Delegate:GetHashCode():int:this (FullOpts)
         -25 (-14.12 % of base) : System.Private.CoreLib.dasm - System.Delegate:GetMethodImpl():System.Reflection.MethodInfo:this (FullOpts)
         -23 (-22.77 % of base) : System.Private.CoreLib.dasm - System.Delegate:TryGetAt(int):System.Delegate:this (FullOpts)
         -14 (-3.63 % of base) : System.Private.CoreLib.dasm - System.Delegate:Equals(System.Object):bool:this (FullOpts)

Top method regressions (percentages):
         311 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate:DeleteFromInvocationList(System.ReadOnlySpan`1[System.Delegate+Wrapper],int,int):System.Delegate+Wrapper[] (FullOpts) (0 base, 1 diff methods)
         200 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate:NewMulticastDelegate(System.Delegate+Wrapper[],int,bool):System.Delegate:this (FullOpts) (0 base, 1 diff methods)
          85 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate:TrySetSlot(byref,System.Delegate):bool (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:.ctor(System.Delegate):this (FullOpts) (0 base, 1 diff methods)
          18 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:Equals(System.Delegate+Wrapper):bool:this (FullOpts) (0 base, 1 diff methods)
          51 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:Equals(System.Object):bool:this (FullOpts) (0 base, 1 diff methods)
          18 (Infinity of base) : System.Private.CoreLib.dasm - System.Delegate+Wrapper:GetHashCode():int:this (FullOpts) (0 base, 1 diff methods)
          58 (59.18 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetResolvedUnmanagedDll(System.Reflection.Assembly,System.String):nint:this (FullOpts)
          63 (39.62 % of base) : System.Private.CoreLib.dasm - System.AppContext:OnUnhandledException(System.Object) (FullOpts)
          63 (39.37 % of base) : System.Private.CoreLib.dasm - System.AppContext:OnFirstChanceException(System.Exception,System.Object) (FullOpts)
          68 (7.25 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:InvokeResolveEvent(System.ResolveEventHandler,System.Reflection.RuntimeAssembly,System.String):System.Reflection.RuntimeAssembly (FullOpts)

Top method improvements (percentages):
        -441 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:DeleteFromInvocationList(System.Object[],int,int,int):System.Object[]:this (FullOpts) (1 base, 0 diff methods)
        -192 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:EqualInvocationLists(System.Object[],System.Object[],int,int):bool (FullOpts) (1 base, 0 diff methods)
        -200 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:NewMulticastDelegate(System.Object[],int,bool):System.Delegate:this (FullOpts) (1 base, 0 diff methods)
        -243 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Delegate:TrySetSlot(System.Object[],int,System.Object):bool (FullOpts) (1 base, 0 diff methods)
         -27 (-23.28 % of base) : System.Private.CoreLib.dasm - System.Delegate:get_Target():System.Object:this (FullOpts)
         -23 (-22.77 % of base) : System.Private.CoreLib.dasm - System.Delegate:TryGetAt(int):System.Delegate:this (FullOpts)
        -258 (-19.91 % of base) : System.Private.CoreLib.dasm - System.Delegate:CombineImpl(System.Delegate):System.Delegate:this (FullOpts)
         -54 (-18.82 % of base) : System.Private.CoreLib.dasm - System.Delegate:GetInvocationList():System.Delegate[]:this (FullOpts)
         -25 (-14.12 % of base) : System.Private.CoreLib.dasm - System.Delegate:GetMethodImpl():System.Reflection.MethodInfo:this (FullOpts)
         -93 (-12.20 % of base) : System.Private.CoreLib.dasm - System.Delegate:RemoveImpl(System.Delegate):System.Delegate:this (FullOpts)
         -25 (-8.93 % of base) : System.Private.CoreLib.dasm - System.Delegate:GetHashCode():int:this (FullOpts)
         -14 (-3.63 % of base) : System.Private.CoreLib.dasm - System.Delegate:Equals(System.Object):bool:this (FullOpts)

23 total methods with Code Size differences (12 improved, 11 regressed), 2115048 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions