chore: require Python 3.10 and modernise type hints#98
Merged
Conversation
- raise the floor to Python 3.10 (setup.py, CI matrices, black target, CONTRIBUTING); 3.9 is end-of-life - replace Optional[X]/Union[...] with X | None / X | Y throughout - use builtin generics (list/dict/tuple/type) instead of typing.List etc - drop the Optional* wrapper aliases from utils.typing and inline at use sites; keep the domain aliases (JsonType, BasicAuthType, XmlType, ResponseType), modernised - fix retry_if_api_request_error status_codes default to list[int] | None
- add 'from __future__ import annotations' so annotations are lazy, then move every type-only import (BasicAuthType, JsonType, XmlType, Callable, Any, requests, and cross-module classes used only in hints) under TYPE_CHECKING - omit the now runtime-dead utils/typing.py (pure type-alias module, imported only under TYPE_CHECKING) from coverage - make paginated()'s callable args optional (Callable | None = None)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X | Noneinstead ofOptional, builtin generics (list/dict/tuple) instead oftyping.Listetc., and inlines theOptional*aliases