From 1dcba51b7652a6cd7b9137d0f84e75c8a9f2468f Mon Sep 17 00:00:00 2001 From: Elaine YIN Date: Mon, 6 Apr 2026 16:39:37 -0700 Subject: [PATCH] fix(config): validate MINIMAX_TIMEOUT env var to prevent NaN crash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Non-numeric values like "abc" produced NaN → AbortSignal.timeout(NaN) threw TypeError. Now invalid values are silently ignored with fallback to 300s. Co-Authored-By: Claude Opus 4.6 --- src/config/loader.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/config/loader.ts b/src/config/loader.ts index dc69d56..3c791ba 100644 --- a/src/config/loader.ts +++ b/src/config/loader.ts @@ -50,10 +50,10 @@ export function loadConfig(flags: GlobalFlags): Config { flags.output || process.env.MINIMAX_OUTPUT || file.output, ); - const timeout = flags.timeout - ?? (process.env.MINIMAX_TIMEOUT ? Number(process.env.MINIMAX_TIMEOUT) : undefined) - ?? file.timeout - ?? 300; + const envTimeout = process.env.MINIMAX_TIMEOUT ? Number(process.env.MINIMAX_TIMEOUT) : undefined; + const validEnvTimeout = envTimeout !== undefined && Number.isFinite(envTimeout) && envTimeout > 0 + ? envTimeout : undefined; + const timeout = flags.timeout ?? validEnvTimeout ?? file.timeout ?? 300; return { apiKey,