Skip to content

Missing check to handle SetSwapchainParameters failure when setting mailbox/immediate #37

Description

@Demorome

Context: libsdl-org/SDL#12837
If I'm reading this issue correctly, it's possible that a setup supports Mailbox present mode, but not necessarily with SDR swapchain composition, notably with the Steam Deck.

Therefore, I believe a check for SDR swapchain composition support (when we're switching away from VSYNC) is missing, to prevent runtime errors to better handle a failure to set the present mode.

if (GraphicsDevice.SupportsPresentMode(MainWindow, PresentMode.Mailbox))

GraphicsDevice.SetSwapchainParameters(MainWindow, SwapchainComposition.SDR, PresentMode.Mailbox);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions