Skip to content

Fix autocomplete stealing keyboard focus on Windows #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarai-dl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix autocomplete stealing keyboard focus on Windows #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions edbee-lib/edbee/views/components/texteditorautocompletecomponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,10 @@ void TextEditorAutoCompleteComponent::positionWidgetForCaretOffset(size_t offset
void TextEditorAutoCompleteComponent::hideEvent(QHideEvent* event)
{
infoTipRef_->hide();
// Restore focus to the editor when autocomplete is hidden
if (editorComponentRef_) {
editorComponentRef_->setFocus();
}
event->isAccepted();
}

Expand Down Expand Up @@ -353,13 +357,15 @@ bool TextEditorAutoCompleteComponent::eventFilter(QObject *obj, QEvent *event)
case Qt::Key_Escape:
menuRef_->close();
canceled_ = true;
editorComponentRef_->setFocus();
return true; // stop event

case Qt::Key_Enter:
case Qt::Key_Return:
case Qt::Key_Tab:
if (listWidgetRef_->currentItem() && currentWord_ == listWidgetRef_->currentItem()->text()) { // sends normal enter/return/tab if you've typed a full word
menuRef_->close();
editorComponentRef_->setFocus();
QApplication::sendEvent(editorComponentRef_, event);
return true;
} else if (listWidgetRef_->currentItem()) {
Expand Down Expand Up @@ -388,6 +394,7 @@ bool TextEditorAutoCompleteComponent::eventFilter(QObject *obj, QEvent *event)

// default operation is to hide and continue the event
menuRef_->close();
editorComponentRef_->setFocus();
QApplication::sendEvent(editorComponentRef_, event);
return true;

Expand Down