Context
Follow-up from #178 (bump data-designer to >=0.6.1,<0.7).
DataDesigner 0.6.1 deprecates ModelConfig(provider=None) and will require an explicit provider in a future release (DD issue #589). The <0.7 cap on our dependency avoids a hard break for now, but we should clean this up before lifting that bound.
Production defaults are already correct: bundled src/anonymizer/config/default_model_configs/models.yaml sets provider: nvidia on every alias, and docs/concepts/models.md documents provider: for custom YAML.
Scope (hardening only)
1. Tests — silence deprecation noise and match future DD behavior
Add explicit provider= on hand-built ModelConfig(...) in tests (currently omit provider):
tests/conftest.py — stub_detector_model_configs, stub_model_configs, stub_known_model_configs
tests/engine/test_ndd_adapter.py — _model_config helper
tests/engine/test_model_loader.py — inline configs in TestValidateAliasReferencesHandlesValidatorPool
Use a consistent test value (e.g. provider="nvidia" or provider="stub").
2. Optional validation — fail fast on user YAML
Before DD 0.7, consider requiring provider on every entry loaded via parse_model_configs() / surfaced in Anonymizer.validate_config() with a clear error (not just a DD DeprecationWarning at runtime).
Out of scope
- Changing bundled default models (already have
provider)
- Bumping
data-designer to 0.7 (separate PR after this)
model_providers / endpoint wiring (already supported; docs exist)
Acceptance criteria
References
Context
Follow-up from #178 (bump
data-designerto>=0.6.1,<0.7).DataDesigner 0.6.1 deprecates
ModelConfig(provider=None)and will require an explicitproviderin a future release (DD issue #589). The<0.7cap on our dependency avoids a hard break for now, but we should clean this up before lifting that bound.Production defaults are already correct: bundled
src/anonymizer/config/default_model_configs/models.yamlsetsprovider: nvidiaon every alias, and docs/concepts/models.md documentsprovider:for custom YAML.Scope (hardening only)
1. Tests — silence deprecation noise and match future DD behavior
Add explicit
provider=on hand-builtModelConfig(...)in tests (currently omitprovider):tests/conftest.py—stub_detector_model_configs,stub_model_configs,stub_known_model_configstests/engine/test_ndd_adapter.py—_model_confighelpertests/engine/test_model_loader.py— inline configs inTestValidateAliasReferencesHandlesValidatorPoolUse a consistent test value (e.g.
provider="nvidia"orprovider="stub").2. Optional validation — fail fast on user YAML
Before DD 0.7, consider requiring
provideron every entry loaded viaparse_model_configs()/ surfaced inAnonymizer.validate_config()with a clear error (not just a DDDeprecationWarningat runtime).Out of scope
provider)data-designerto0.7(separate PR after this)model_providers/ endpoint wiring (already supported; docs exist)Acceptance criteria
make testpasses with noModelConfig.provider=None is deprecatedwarnings from our fixturesprovideris rejected with an actionable Anonymizer error<0.7that this issue was filedReferences
providerfield, issue #589