From 191f72db1784f3f64a4edd745afae558f860ce83 Mon Sep 17 00:00:00 2001 From: Drew Newberry Date: Sat, 21 Mar 2026 08:46:59 -0700 Subject: [PATCH] fix(docker): enable dev-settings feature by default in local builds Local image builds via mise run cluster / mise run docker:build:* were missing the dev-settings feature flag, causing e2e tests to fail with 'unknown setting key dummy_bool'. CI sets EXTRA_CARGO_FEATURES explicitly but the local path did not. Default EXTRA_CARGO_FEATURES to openshell-core/dev-settings so local builds match CI. The variable can still be overridden by the caller. --- tasks/scripts/docker-build-image.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tasks/scripts/docker-build-image.sh b/tasks/scripts/docker-build-image.sh index f8da08c4..3675d754 100755 --- a/tasks/scripts/docker-build-image.sh +++ b/tasks/scripts/docker-build-image.sh @@ -159,8 +159,12 @@ else exit 1 fi +# Default to dev-settings so local builds include test-only settings +# (dummy_bool, dummy_int) that e2e tests depend on, matching CI behaviour. +EXTRA_CARGO_FEATURES="${EXTRA_CARGO_FEATURES:-openshell-core/dev-settings}" + FEATURE_ARGS=() -if [[ -n "${EXTRA_CARGO_FEATURES:-}" ]]; then +if [[ -n "${EXTRA_CARGO_FEATURES}" ]]; then FEATURE_ARGS=(--build-arg "EXTRA_CARGO_FEATURES=${EXTRA_CARGO_FEATURES}") fi