Address comments from Copilot

Author: mdboom

cuda_bindings/cuda/bindings/_nvml.pyx

@@ -26829,7 +26829,7 @@ cpdef object device_get_topology_nearest_gpus(intptr_t device, unsigned int leve
     check_status_size(__status__)
     if count[0] == 0:
         return view.array(shape=(1,), itemsize=sizeof(intptr_t), format="P", mode="c")[:0]
-    cdef view.array deviceArray = view.array(shape=(deviceCount[0],), itemsize=sizeof(intptr_t), format="P", mode="c")
+    cdef view.array deviceArray = view.array(shape=(count[0],), itemsize=sizeof(intptr_t), format="P", mode="c")
     with nogil:
         __status__ = nvmlDeviceGetTopologyNearestGpus(
             <Device>device,

cuda_core/cuda/core/system/_device.pyx

@@ -21,6 +21,7 @@ ClocksEventReasons = nvml.ClocksEventReasons
 ClockType = nvml.ClockType
 CoolerControl = nvml.CoolerControl
 CoolerTarget = nvml.CoolerTarget
+FanControlPolicy = nvml.FanControlPolicy
 FieldId = nvml.FieldId
 GpuP2PCapsIndex = nvml.GpuP2PCapsIndex
 GpuP2PStatus = nvml.GpuP2PStatus
@@ -723,7 +724,7 @@ cdef class Device:
 
         On Pascal™ and newer hardware, Auto Boosted clocks are controlled
         through application clocks. Use :meth:`set_application_clocks` and
-        :methd:`reset_application_clocks` to control Auto Boost behavior.
+        :meth:`reset_application_clocks` to control Auto Boost behavior.
 
         Returns
         -------
@@ -1170,6 +1171,7 @@ __all__ = [
     "Device",
     "DeviceArchitecture",
     "DeviceAttributes",
+    "FanControlPolicy",
     "FanInfo",
     "FieldId",
     "FieldValue",

cuda_core/docs/source/api.rst

@@ -99,6 +99,7 @@ CUDA system information and NVIDIA Management Library (NVML)
    system.CoolerTarget
    system.DeviceArchitecture
    system.DeviceAttributes
+   system.FanControlPolicy
    system.FanInfo
    system.FieldId
    system.FieldValue

cuda_core/tests/system/test_system_device.py

@@ -529,47 +529,45 @@ def test_clock():
             clock = device.clock(clock_type)
             assert isinstance(clock, system.ClockInfo)
 
-            for clock_type in system.ClockType:
-                try:
-                    current_mhz = clock.get_current_mhz()
-                except system.NotSupportedError:
-                    continue
-                assert isinstance(current_mhz, int)
-                assert current_mhz >= 0
-
-                current_mhz = clock.get_current_mhz(system.ClockId.CURRENT)
-                assert isinstance(current_mhz, int)
-                assert current_mhz >= 0
-
-                max_mhz = clock.get_max_mhz()
-                assert isinstance(max_mhz, int)
-                assert max_mhz >= 0
-
-                try:
-                    max_customer_boost = clock.get_max_customer_boost_mhz()
-                except system.NotSupportedError:
-                    pass
-                else:
-                    assert isinstance(max_customer_boost, int)
-                    assert max_customer_boost >= 0
-
-                pstate = device.performance_state
-
-                min_, max_ = clock.get_min_max_clock_of_pstate_mhz(pstate)
-                assert isinstance(min_, int)
-                assert min_ >= 0
-                assert isinstance(max_, int)
-                assert max_ >= 0
+            try:
+                current_mhz = clock.get_current_mhz()
+            except system.NotSupportedError:
+                continue
+            assert isinstance(current_mhz, int)
+            assert current_mhz >= 0
+
+            current_mhz = clock.get_current_mhz(system.ClockId.CURRENT)
+            assert isinstance(current_mhz, int)
+            assert current_mhz >= 0
+
+            max_mhz = clock.get_max_mhz()
+            assert isinstance(max_mhz, int)
+            assert max_mhz >= 0
 
-                try:
-                    offsets = clock.get_offsets(pstate)
-                except system.InvalidArgumentError:
-                    offsets = system.ClockOffsets(nvml.ClockOffset_v1())
-                else:
-                    assert isinstance(offsets, system.ClockOffsets)
-                    assert isinstance(offsets.clock_offset_mhz, int)
-                    assert isinstance(offsets.max_offset_mhz, int)
-                    assert isinstance(offsets.min_offset_mhz, int)
+            try:
+                max_customer_boost = clock.get_max_customer_boost_mhz()
+            except system.NotSupportedError:
+                pass
+            else:
+                assert isinstance(max_customer_boost, int)
+                assert max_customer_boost >= 0
+
+            pstate = device.performance_state
+
+            min_, max_ = clock.get_min_max_clock_of_pstate_mhz(pstate)
+            assert isinstance(min_, int)
+            assert min_ >= 0
+            assert isinstance(max_, int)
+            assert max_ >= 0
+
+            try:
+                offsets = clock.get_offsets(pstate)
+            except system.InvalidArgumentError:
+                offsets = system.ClockOffsets(nvml.ClockOffset_v1())
+            assert isinstance(offsets, system.ClockOffsets)
+            assert isinstance(offsets.clock_offset_mhz, int)
+            assert isinstance(offsets.max_offset_mhz, int)
+            assert isinstance(offsets.min_offset_mhz, int)
 
 
 def test_clock_event_reasons():
@@ -624,7 +622,7 @@ def test_cooler():
         assert isinstance(cooler_info, system.CoolerInfo)
 
         signal_type = cooler_info.signal_type
-        assert isinstance(signal_type, system.CoolerSignalType)
+        assert isinstance(signal_type, system.CoolerControl)
 
         target = cooler_info.target
         assert all(isinstance(t, system.CoolerTarget) for t in target)