Skip to content

Commit 51d5fda

Browse files
leofangclaude
andcommitted
Drop CIBW_REPAIR_WHEEL_COMMAND_WINDOWS override; version-gate matplotlib/cffi
Remove the empty CIBW_REPAIR_WHEEL_COMMAND_WINDOWS that was overriding the pyproject.toml delvewheel config. The pyproject.toml already specifies `delvewheel repair --namespace-pkg cuda` which is the correct behavior. Keep matplotlib and cffi as test dependencies but gate them to python_version < 3.15 (no wheels available yet for 3.15). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d120029 commit 51d5fda

3 files changed

Lines changed: 2 additions & 13 deletions

File tree

.github/workflows/build-wheel.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,6 @@ jobs:
174174
# no-op for stable Python versions because CIBW_BUILD still filters
175175
# the target version.
176176
CIBW_ENABLE: cpython-prerelease
177-
# v4.0 made delvewheel the default Windows repair command. We rely
178-
# on cuda.pathfinder for runtime DLL discovery, so preserve the
179-
# previous behaviour (no automatic DLL bundling) for now.
180-
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: ""
181177
# CIBW mounts the host filesystem under /host
182178
CIBW_ENVIRONMENT_LINUX: >
183179
CUDA_PATH=/host/${{ env.CUDA_PATH }}
@@ -246,10 +242,6 @@ jobs:
246242
# no-op for stable Python versions because CIBW_BUILD still filters
247243
# the target version.
248244
CIBW_ENABLE: cpython-prerelease
249-
# v4.0 made delvewheel the default Windows repair command. We rely
250-
# on cuda.pathfinder for runtime DLL discovery, so preserve the
251-
# previous behaviour (no automatic DLL bundling) for now.
252-
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: ""
253245
# CIBW mounts the host filesystem under /host
254246
CIBW_ENVIRONMENT_LINUX: >
255247
CUDA_PATH=/host/${{ env.CUDA_PATH }}
@@ -502,10 +494,6 @@ jobs:
502494
# no-op for stable Python versions because CIBW_BUILD still filters
503495
# the target version.
504496
CIBW_ENABLE: cpython-prerelease
505-
# v4.0 made delvewheel the default Windows repair command. We rely
506-
# on cuda.pathfinder for runtime DLL discovery, so preserve the
507-
# previous behaviour (no automatic DLL bundling) for now.
508-
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: ""
509497
# CIBW mounts the host filesystem under /host
510498
CIBW_ENVIRONMENT_LINUX: >
511499
CUDA_PATH=/host/${{ env.CUDA_PATH }}

cuda_bindings/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ all = [
4646
test = [
4747
"cython>=3.2,<3.3",
4848
"setuptools>=77.0.0",
49+
"matplotlib>=3.5.0; python_version < '3.15'",
4950
"numpy>=1.21.1",
5051
"pytest>=6.2.4",
5152
"pytest-benchmark>=3.4.1",

cuda_core/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ cu12 = ["cuda-bindings[all]==12.*", "cuda-toolkit==12.*"]
5858
cu13 = ["cuda-bindings[all]==13.*", "cuda-toolkit==13.*"]
5959

6060
[dependency-groups]
61-
test = ["cython>=3.2,<3.3", "setuptools", "pytest>=6.2.4", "pytest-benchmark", "pytest-randomly", "pytest-repeat", "pytest-rerunfailures", "pytest-timeout", "cloudpickle", "psutil"]
61+
test = ["cython>=3.2,<3.3", "setuptools", "pytest>=6.2.4", "pytest-benchmark", "pytest-randomly", "pytest-repeat", "pytest-rerunfailures", "pytest-timeout", "cloudpickle", "psutil", "cffi; python_version < '3.15'"]
6262
ml-dtypes = ["ml-dtypes>=0.5.4,<0.6.0"]
6363
test-cu12 = [ {include-group = "ml-dtypes" }, {include-group = "test" }, "cupy-cuda12x; python_version < '3.14'", "cuda-toolkit[cudart]==12.*"] # runtime headers needed by CuPy
6464
test-cu13 = [ {include-group = "ml-dtypes" }, {include-group = "test" }, "cupy-cuda13x; python_version < '3.14'", "cuda-toolkit[cudart]==13.*"] # runtime headers needed by CuPy

0 commit comments

Comments
 (0)