Skip to content

Commit d1b8d82

Browse files
leofangclaude
andcommitted
Fix Windows numpy build; allow 3.15 test failures
- Skip musllinux and win32 when building numpy (CIBW_BUILD=cp315-* matches both win32 and win_amd64; numpy has no pyproject.toml constraint after we strip its cibuildwheel config) - Mark 3.15/3.15t test jobs as continue-on-error so they don't block CI (3.15t segfaults on CPython beta, rlcompleter test changed behavior) - Skip test_opt_out_env_var_disables_patch_even_when_interactive on Python 3.15 (upstream fixed the rlcompleter bug this test relied on) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 2f7a05b commit d1b8d82

4 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/build-wheel.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ jobs:
396396
uses: pypa/cibuildwheel@54327ab9d35de03b359ac25c97de9417d94639c0 # v4.0.0rc1
397397
env:
398398
CIBW_BUILD: ${{ env.CIBW_BUILD }}
399-
CIBW_SKIP: "*-musllinux*"
399+
CIBW_SKIP: "*-musllinux* *-win32"
400400
CIBW_ARCHS_LINUX: "native"
401401
CIBW_BUILD_VERBOSITY: 1
402402
CIBW_CONFIG_SETTINGS: "setup-args=-Dallow-noblas=true"

.github/workflows/test-wheel-linux.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ jobs:
102102
fail-fast: false
103103
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
104104
runs-on: "${{ matrix.FLAVOR || 'linux' }}-${{ matrix.ARCH }}-gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-${{ matrix.GPU_COUNT }}"
105+
continue-on-error: ${{ startsWith(matrix.PY_VER, '3.15') }}
105106
# The build stage could fail but we want the CI to keep moving.
106107
if: ${{ github.repository_owner == 'nvidia' && !cancelled() }}
107108
# Our self-hosted runners require a container

.github/workflows/test-wheel-windows.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ jobs:
9595
fail-fast: false
9696
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
9797
if: ${{ github.repository_owner == 'nvidia' && !cancelled() }}
98+
continue-on-error: ${{ startsWith(matrix.PY_VER, '3.15') }}
9899
runs-on: "windows-${{ matrix.ARCH }}-gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-${{ matrix.GPU_COUNT }}"
99100
steps:
100101
- name: Checkout ${{ github.event.repository.name }}

cuda_core/tests/test_rlcompleter_patch.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ def test_patched_completion_succeeds_on_non_ipc_resource():
9696
assert "allocation_handle: True" in result.stdout, result.stdout
9797

9898

99+
@pytest.mark.skipif(sys.version_info >= (3, 15), reason="Python 3.15 fixed the rlcompleter bug upstream")
99100
def test_opt_out_env_var_disables_patch_even_when_interactive():
100101
"""`CUDA_CORE_DONT_FIX_TAB_COMPLETION=1` must short-circuit before the
101102
interactive check, so the bug reproduces again even under PYTHONINSPECT."""

0 commit comments

Comments
 (0)