Skip to content

Commit d757fa0

Browse files
rwgkcursoragent
andcommitted
test: rename pinned helper for xfail flow
Clarify pinned mempool test setup by keeping skip for capability checks and using xfail naming for the Windows MCDM constructor workaround. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 6e790f7 commit d757fa0

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

cuda_core/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def create_managed_memory_resource_or_skip(*args, xfail_device=None, **kwargs):
8585
raise
8686

8787

88-
def create_pinned_memory_resource_or_skip(*args, xfail_device=None, **kwargs):
88+
def create_pinned_memory_resource_or_xfail(*args, xfail_device=None, **kwargs):
8989
try:
9090
return PinnedMemoryResource(*args, **kwargs)
9191
except CUDAError as e:

cuda_core/tests/test_memory.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
from conftest import (
2424
create_managed_memory_resource_or_skip,
25-
create_pinned_memory_resource_or_skip,
25+
create_pinned_memory_resource_or_xfail,
2626
skip_if_managed_memory_unsupported,
2727
skip_if_pinned_memory_unsupported,
2828
)
@@ -640,7 +640,7 @@ def test_non_managed_resources_report_not_managed(mr_kind):
640640
mr = DeviceMemoryResource(device)
641641
else:
642642
skip_if_pinned_memory_unsupported(device)
643-
mr = create_pinned_memory_resource_or_skip(xfail_device=device)
643+
mr = create_pinned_memory_resource_or_xfail(xfail_device=device)
644644
assert mr.is_managed is False
645645
buf = mr.allocate(1024)
646646
assert buf.is_managed is False
@@ -685,7 +685,7 @@ def test_pinned_memory_resource_initialization(init_cuda):
685685

686686
device.set_current()
687687

688-
mr = create_pinned_memory_resource_or_skip(xfail_device=device)
688+
mr = create_pinned_memory_resource_or_xfail(xfail_device=device)
689689
assert mr.is_device_accessible
690690
assert mr.is_host_accessible
691691

@@ -1582,7 +1582,7 @@ def test_memory_resource_alloc_zero_bytes(init_cuda, memory_resource_factory):
15821582
pytest.skip("Device does not support mempool operations")
15831583
elif MR is PinnedMemoryResource:
15841584
skip_if_pinned_memory_unsupported(device)
1585-
mr = create_pinned_memory_resource_or_skip(xfail_device=device)
1585+
mr = create_pinned_memory_resource_or_xfail(xfail_device=device)
15861586
elif MR is ManagedMemoryResource:
15871587
skip_if_managed_memory_unsupported(device)
15881588
mr = create_managed_memory_resource_or_skip(MROps(preferred_location=device.device_id))

0 commit comments

Comments
 (0)