Skip to content

Commit ec524c6

Browse files
committed
address review feedback for issue 980 PR
Raise the cuda-core dependency floor to cuda-pathfinder>=1.4.2, move the new optional import note to 1.4.2 release notes, and simplify nvJitLink warning text by inlining the fixed version detail. Made-with: Cursor
1 parent 800a0cb commit ec524c6

4 files changed

Lines changed: 17 additions & 8 deletions

File tree

cuda_core/cuda/core/_linker.pyx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -662,9 +662,8 @@ def _decide_nvjitlink_or_driver() -> bool:
662662
if _nvjitlink_has_version_symbol(nvjitlink):
663663
_use_nvjitlink_backend = True
664664
return False # Use nvjitlink
665-
warn_detail = "too old (<12.3)"
666665
warn_txt = (
667-
f"{'nvJitLink*.dll' if sys.platform == 'win32' else 'libnvJitLink.so*'} is {warn_detail}."
666+
f"{'nvJitLink*.dll' if sys.platform == 'win32' else 'libnvJitLink.so*'} is too old (<12.3)."
668667
f" Therefore cuda.bindings.nvjitlink is not usable and {warn_txt_common} nvJitLink."
669668
)
670669

cuda_core/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ classifiers = [
4747
"Environment :: GPU :: NVIDIA CUDA :: 13",
4848
]
4949
dependencies = [
50-
"cuda-pathfinder >=1.1",
50+
"cuda-pathfinder >=1.4.2",
5151
"numpy",
5252
]
5353

cuda_pathfinder/docs/source/release/1.4.1-notes.rst

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,6 @@ Highlights
3333
libraries: site-packages, Conda, then CUDA_HOME/CUDA_PATH.
3434
(`PR #1690 <https://github.com/NVIDIA/cuda-python/pull/1690>`_)
3535

36-
* Add ``optional_cuda_import()`` to support robust optional imports of CUDA
37-
Python modules. It returns ``None`` when the requested module is absent or a
38-
probe hits ``DynamicLibNotFoundError``, while still re-raising unrelated
39-
``ModuleNotFoundError`` exceptions (for missing transitive dependencies).
40-
4136
* Fix site-packages search order for virtual environments created with
4237
``--system-site-packages``. The search now correctly prioritizes the venv's
4338
site-packages before user-site-packages, conforming to PEP 405.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
.. SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
.. SPDX-License-Identifier: Apache-2.0
3+
4+
.. py:currentmodule:: cuda.pathfinder
5+
6+
``cuda-pathfinder`` 1.4.2 Release notes
7+
=======================================
8+
9+
Highlights
10+
----------
11+
12+
* Add ``optional_cuda_import()`` to support robust optional imports of CUDA
13+
Python modules. It returns ``None`` when the requested module is absent or a
14+
probe hits ``DynamicLibNotFoundError``, while still re-raising unrelated
15+
``ModuleNotFoundError`` exceptions (for missing transitive dependencies).

0 commit comments

Comments
 (0)