From 8ac79f70b8fa4750ab9f6460e3b56809898b9aa5 Mon Sep 17 00:00:00 2001
From: luojiyin <luojiyin@hotmail.com>
Date: Fri, 19 Dec 2025 17:52:40 +0800
Subject: [PATCH] improve ssh key handling in e2e workflow   - use trap to
 ensure temp key file cleanup on exit   - use printf instead of echo for safer
 secret handling

Signed-off-by: luojiyin <luojiyin@hotmail.com>
---
 .github/workflows/e2e.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
index 6193b028e..6b4b8cb2c 100644
--- a/.github/workflows/e2e.yaml
+++ b/.github/workflows/e2e.yaml
@@ -93,7 +93,8 @@ jobs:
           E2E_SSH_HOST: ${{ steps.holodeck_public_dns_name.outputs.result }}
         run: |
           e2e_ssh_key=$(mktemp)
-          echo "${{ secrets.AWS_SSH_KEY }}" > "$e2e_ssh_key"
+          trap 'rm -f "$e2e_ssh_key"' EXIT
+          printf '%s' "${{ secrets.AWS_SSH_KEY }}" > "$e2e_ssh_key"
           chmod 600 "$e2e_ssh_key"
           export E2E_SSH_KEY="$e2e_ssh_key"