From ddac32d732310817785c73a7e4ef55dea58a689a Mon Sep 17 00:00:00 2001 From: Jean Paul Elisa NIYOKWIZERWA <140616733+Ndevu12@users.noreply.github.com> Date: Mon, 23 Mar 2026 23:10:21 +0200 Subject: [PATCH] Potential fix for code scanning alert no. 21: Information exposure through an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- api/views/sales.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/views/sales.py b/api/views/sales.py index 057018b..a29ac26 100644 --- a/api/views/sales.py +++ b/api/views/sales.py @@ -57,9 +57,9 @@ def confirm(self, request, pk=None): sales_order=so, confirmed_by=request.user, ) - except DjangoValidationError as e: + except DjangoValidationError: return Response( - {"detail": e.message if hasattr(e, "message") else str(e)}, + {"detail": "Invalid data for confirming sales order."}, status=status.HTTP_400_BAD_REQUEST, ) return Response(self.get_serializer(so).data) @@ -71,9 +71,9 @@ def cancel(self, request, pk=None): service = SalesService() try: service.cancel_order(sales_order=so) - except DjangoValidationError as e: + except DjangoValidationError: return Response( - {"detail": e.message if hasattr(e, "message") else str(e)}, + {"detail": "Invalid data for cancelling sales order."}, status=status.HTTP_400_BAD_REQUEST, ) return Response(self.get_serializer(so).data) @@ -103,9 +103,9 @@ def process(self, request, pk=None): dispatch=dispatch, dispatched_by=request.user, ) - except DjangoValidationError as e: + except DjangoValidationError: return Response( - {"detail": e.message if hasattr(e, "message") else str(e)}, + {"detail": "Invalid data for processing dispatch."}, status=status.HTTP_400_BAD_REQUEST, ) dispatch.refresh_from_db()