From d0b710d683822131912f4f4250c2f77b843c25e9 Mon Sep 17 00:00:00 2001 From: Guennadi Maximov C Date: Sat, 4 Oct 2025 12:46:42 -0600 Subject: [PATCH 1/2] fix(window): improved conditionals, comments added Signed-off-by: Guennadi Maximov C --- lua/lsp-toggle/window.lua | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lua/lsp-toggle/window.lua b/lua/lsp-toggle/window.lua index 422fe0a..fe812e3 100644 --- a/lua/lsp-toggle/window.lua +++ b/lua/lsp-toggle/window.lua @@ -1,11 +1,15 @@ local utils = require('lsp-toggle.utils') local M = {} + +---@type string[] M.out_buf_table = {} ---@param clients table function M.print_display(clients) M.out_buf_table = {} + + -- NOTE: Using `#clients` is not reliable because `clients` is not list-like for _, tb_server in pairs(clients) do table.insert( M.out_buf_table, @@ -28,16 +32,14 @@ function M.open_window() return end - local opts = require('lsp-toggle.config').options - utils.merge_table_pf() - local dynamic_height = 0 for _, _ in pairs(utils.clients) do - dynamic_height = dynamic_height + 1 + dynamic_height = dynamic_height + 1 ---@type integer end - if dynamic_height <= 0 or dynamic_height >= opts.max_height then + local opts = require('lsp-toggle.config').options + if dynamic_height < 1 or dynamic_height > opts.max_height then dynamic_height = 1 end From 1b7c68729b5be98377aeb5a3620f6b7c0748515a Mon Sep 17 00:00:00 2001 From: Guennadi Maximov C Date: Sat, 4 Oct 2025 12:47:20 -0600 Subject: [PATCH 2/2] fix(window): `nvim_set_option_value()` --> `vim.bo` Signed-off-by: Guennadi Maximov C --- lua/lsp-toggle/window.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lua/lsp-toggle/window.lua b/lua/lsp-toggle/window.lua index fe812e3..4f07042 100644 --- a/lua/lsp-toggle/window.lua +++ b/lua/lsp-toggle/window.lua @@ -19,9 +19,9 @@ function M.print_display(clients) local safe_fn = vim.schedule_wrap(function() vim.api.nvim_buf_set_lines(M.window_buf, 0, -1, false, M.out_buf_table) - vim.api.nvim_set_option_value('modifiable', false, { buf = M.window_buf }) + vim.bo[M.window_buf].modifiable = false end) - vim.api.nvim_set_option_value('modifiable', true, { buf = M.window_buf }) + vim.bo[M.window_buf].modifiable = true safe_fn() end