ci: Fix remaining issues spotted by Zizmor#399
Merged
Conversation
A scan using Zizmor with the default persona now comes clean. https://docs.zizmor.sh/ Permissions of the release workflow have been limited to only what's needed. Once the treefmt-nix pin is updated to something more recent it will be possible to activate Zizmor in the Treefmt config (and so have it verified during CI checks).
jfly
approved these changes
May 21, 2026
Collaborator
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Thanks!
Once the treefmt-nix pin is updated to something more recent it will be possible to activate Zizmor (programs.zizmor.enable = true;) in the Treefmt config (and so have it verified during CI checks).
We're getting close to this (#389). Do you mind sending in a PR that adds this? It'll fail right now, but serve as a reminder to enable this once the updates have landed.
Contributor
|
We could also use nixpkgs' EDIT: seems our pinned nixpkgs pre-dates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scan using Zizmor with the default persona now comes clean.
Permissions of the release workflow have been limited to only what's needed.
Once the treefmt-nix pin is updated to something more recent it will be possible to activate Zizmor (
programs.zizmor.enable = true;) in the Treefmt config (and so have it verified during CI checks).