[1.20/1.3.3] Missing crop textures

[JL2210]

(and yes, this was hell to debug. Don't even ask.)

I think previously the mod would try to automatically pull textures from block/cropname_[0-7]? That doesn't appear to work now. Dead and young dead crops still work.

This commit looks to be the culprit (present starting in 1.3.2): 7dc357e

before:

KubeJS-TFC/src/main/java/com/notenoughmail/kubejs_tfc/block/internal/AbstractCropBlockBuilder.java

Lines 293 to 297 in e4c057e

	final String texture = newID("block/", "_" + i).toString();
	generator.blockModel(age, m -> {
	m.parent("block/crop");
	m.texture("crop", texture);
	});

after:

KubeJS-TFC/src/main/java/com/notenoughmail/kubejs_tfc/block/internal/AbstractCropBlockBuilder.java

Lines 274 to 279 in 7dc357e

	@Override
	protected void generateBlockModelJsons(AssetJsonGenerator generator) {
	for (int i = 0 ; i <= stages ; i++) {
	generator.blockModel(newID("", "_age_" + i), models[i]);
	}
	}

workaround (in code):

const cropCropname = e.create("modid:cropname", "tfc:crop");
for(var i = 0; i < 8; i++) {
  cropCropname.textureAt(i, "modid:block/cropname_" + i);
}

While I was at it it looks like I found an off-by-one error here as well? Should be <stages and not <=? Might be too late to fix this one.

KubeJS-TFC/src/main/java/com/notenoughmail/kubejs_tfc/block/internal/AbstractCropBlockBuilder.java

Lines 275 to 287 in 8ee8781

	@Override
	protected void generateBlockModelJsons(AssetJsonGenerator generator) {
	for (int i = 0 ; i <= stages ; i++) {
	generator.blockModel(newID("", "_age_" + i), models[i]);
	}
	}
	@Override
	protected void generateBlockStateJson(VariantBlockStateGenerator bs) {
	for (int i = 0 ; i <= stages ; i++) {
	bs.simpleVariant("age=" + i, newID("block/", "_age_" + i).toString());
	}
	}

[Notenoughmail]

Using <= is intended, the age property is in the range [0, stages] as per TFC's available properties

As for the textures, I believe this change was made to bring crops in line with other block builders which do not provide any textures by default. This is tangentially mentioned in the last point of the 1.3.2 changelog, it should have mentioned that the default texture is unset by default as well

I've wanted to document the texture keys for all of the block and item types for a while now, but that's been a low priority unfortunately