From 2a4cfeb27020d177cb79e32acbd03d6e49c645c4 Mon Sep 17 00:00:00 2001
From: namtnt <nam-tnt@komit-consulting.com>
Date: Wed, 4 Mar 2026 17:08:36 +0700
Subject: [PATCH] [19.0][FIX] base_user_role: Cannot see User Roles in list
 view, even though the user has roles in form view

---
 base_user_role/models/user.py          | 6 +++---
 base_user_role/tests/test_user_role.py | 2 +-
 base_user_role/views/user.xml          | 8 ++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/base_user_role/models/user.py b/base_user_role/models/user.py
index efd6d4102..121ae7c59 100644
--- a/base_user_role/models/user.py
+++ b/base_user_role/models/user.py
@@ -21,9 +21,9 @@ def _compute_show_alert(self):
         for user in self:
             user.show_alert = user.role_line_ids.filtered(lambda rec: rec.is_enabled)
 
-    role_ids = fields.One2many(
+    user_role_ids = fields.One2many(
         comodel_name="res.users.role",
-        string="User Roles",
+        string="Roles",
         compute="_compute_role_ids",
         compute_sudo=True,
         groups="base.group_erp_manager",
@@ -44,7 +44,7 @@ def _default_role_lines(self):
     @api.depends("role_line_ids.role_id")
     def _compute_role_ids(self):
         for user in self:
-            user.role_ids = user.role_line_ids.mapped("role_id")
+            user.user_role_ids = user.role_line_ids.mapped("role_id")
 
     @api.model_create_multi
     def create(self, vals_list):
diff --git a/base_user_role/tests/test_user_role.py b/base_user_role/tests/test_user_role.py
index 5c014a1e1..09dbdf78b 100644
--- a/base_user_role/tests/test_user_role.py
+++ b/base_user_role/tests/test_user_role.py
@@ -208,7 +208,7 @@ def test_default_user_roles(self):
             {"name": "USER TEST (DEFAULT ROLES)", "login": "user_test_default_roles"}
         )
         roles = self.role_model.browse([self.role1_id.id, self.role2_id.id])
-        self.assertEqual(user.role_ids, roles)
+        self.assertEqual(user.user_role_ids, roles)
 
     def test_role_multicompany(self):
         """Test AccessError when admin-like user accesses a role"""
diff --git a/base_user_role/views/user.xml b/base_user_role/views/user.xml
index e2c6e2b74..5e1f80deb 100644
--- a/base_user_role/views/user.xml
+++ b/base_user_role/views/user.xml
@@ -10,12 +10,12 @@
         <field name="arch" type="xml">
             <xpath expr="//notebook/page[1]" position="before">
                 <page string="User Roles">
-                    <field name="role_ids" invisible="1" />
+                    <field name="user_role_ids" invisible="1" />
                     <field name="role_line_ids" nolabel="1">
                         <list editable="bottom" decoration-muted="not is_enabled">
                             <field
                                 name="role_id"
-                                domain="[('id', 'not in', parent.role_ids)]"
+                                domain="[('id', 'not in', parent.user_role_ids)]"
                             />
                             <field name="date_from" />
                             <field name="date_to" />
@@ -52,7 +52,7 @@
         <field name="arch" type="xml">
             <field name="company_ids" position="after">
                 <field
-                    name="role_ids"
+                    name="user_role_ids"
                     filter_domain="[('role_line_ids.role_id.name','ilike',self)]"
                 />
             </field>
@@ -63,7 +63,7 @@
         <field name="inherit_id" ref="base.view_users_tree" />
         <field name="arch" type="xml">
             <field name="role" position="after">
-                <field name="role_ids" widget="many2many_tags" />
+                <field name="user_role_ids" widget="many2many_tags" />
             </field>
         </field>
     </record>