Question: Hardcoded edition version in card route loader

[theanand108]

While exploring the card routing logic I noticed that version resolution is handled differently in two similar routes.

In:

src/routes/edition/[edition]/+page.server.ts

the version is determined using:

const version = DeckService.getLatestVersion(edition);

However in:

src/routes/edition/[edition]/[card]/+page.server.ts

the version is hardcoded:

const version = edition == 'webapp'
  ? '2.2'
  : edition == 'mobileapp'
  ? '1.1'
  : '1.0';

I wanted to ask whether this difference is intentional (for example to lock the card route to specific versions), or if it would make sense to use DeckService.getLatestVersion() here as well for consistency.

Happy to submit a PR if aligning these would be appropriate.

[kavya-seth-vns]

Opened PR #2616 to address this issue by replacing the hardcoded
version logic with DeckService.getLatestVersion(edition).

Happy to make any changes if needed.

[theanand108]

Thanks for taking a look and submitting a PR!

I opened the issue after noticing that src/routes/edition/[edition]/+page.server.ts already uses DeckService.getLatestVersion(edition) while the [card] route had hardcoded values. Your approach seems to align with the intention of keeping the version logic centralized.

Looking forward to the maintainer’s feedback on the PR.