From 6d4e72f7f78464ebd14a9bafe825337157869ac7 Mon Sep 17 00:00:00 2001 From: Sam Crauwels Date: Mon, 9 Mar 2026 08:22:29 +0100 Subject: [PATCH] Pin deploy_docs action versions and fix ansible deprecation imports Pin all GitHub Actions in deploy_docs.yml to commit SHAs (checkout v6.0.1, setup-python v6.2.0, upload-pages-artifact v4.0.0, deploy-pages v4.0.5). Move to_native/to_text/to_bytes imports from ansible.module_utils.basic to ansible.module_utils.common.text.converters, fixing the deprecation warning introduced in ansible-core 2.17. Closes #84 --- .github/workflows/deploy_docs.yml | 8 ++++---- plugins/module_utils/certs.py | 8 ++------ plugins/modules/cert_info.py | 6 ++---- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/.github/workflows/deploy_docs.yml b/.github/workflows/deploy_docs.yml index 64852fa6..7e09cc90 100644 --- a/.github/workflows/deploy_docs.yml +++ b/.github/workflows/deploy_docs.yml @@ -22,9 +22,9 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - - uses: actions/setup-python@v5 + - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 with: python-version: '3.12' @@ -34,7 +34,7 @@ jobs: - name: Build site run: mkdocs build --strict - - uses: actions/upload-pages-artifact@v3 + - uses: actions/upload-pages-artifact@7b1f4a764d45c48632c6b24a0339c27f5614fb0b # v4.0.0 with: path: site @@ -45,5 +45,5 @@ jobs: name: github-pages url: ${{ steps.deployment.outputs.page_url }} steps: - - uses: actions/deploy-pages@v4 + - uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5 id: deployment diff --git a/plugins/module_utils/certs.py b/plugins/module_utils/certs.py index 65a78dbb..13935f1a 100644 --- a/plugins/module_utils/certs.py +++ b/plugins/module_utils/certs.py @@ -8,12 +8,8 @@ from __future__ import absolute_import, division, print_function __metaclass__ = type -from ansible.module_utils.basic import ( - missing_required_lib, - to_text, - to_native, - to_bytes -) +from ansible.module_utils.basic import missing_required_lib +from ansible.module_utils.common.text.converters import to_text, to_native, to_bytes try: from cryptography.hazmat.primitives.serialization import pkcs12 diff --git a/plugins/modules/cert_info.py b/plugins/modules/cert_info.py index e315ca64..d55289e6 100644 --- a/plugins/modules/cert_info.py +++ b/plugins/modules/cert_info.py @@ -9,10 +9,8 @@ from __future__ import (absolute_import, division, print_function) __metaclass__ = type -from ansible.module_utils.basic import ( - AnsibleModule, - to_native -) +from ansible.module_utils.basic import AnsibleModule +from ansible.module_utils.common.text.converters import to_native from ansible_collections.oddly.elasticstack.plugins.module_utils.certs import ( AnalyzeCertificate