From dbbcff39a4d6b401b6eae7550d7e37b48ce26834 Mon Sep 17 00:00:00 2001 From: Fadi George Date: Thu, 18 Jun 2026 11:14:41 -0700 Subject: [PATCH 1/2] ci: fix android version regex in release PR --- .github/workflows/create-release-pr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml index abce977f..4771a8f7 100644 --- a/.github/workflows/create-release-pr.yml +++ b/.github/workflows/create-release-pr.yml @@ -85,7 +85,7 @@ jobs: # Get versions from target branch (not the release branch) CURRENT_VERSION=$(git show origin/${{ inputs.target_branch }}:pubspec.yaml | grep "^version:" | sed 's/version: //' | tr -d ' ') - ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | sed -n "s/.*com\.onesignal:OneSignal:\([^']*\)'.*/\1/p") + ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | sed -n "s/^def oneSignalVersion = ['\"]\([^'\"]*\)['\"].*/\1/p") IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:ios/onesignal_flutter.podspec | sed -n "s/.*OneSignalXCFramework', '\([^']*\)'.*/\1/p") echo "flutter_from=$CURRENT_VERSION" >> $GITHUB_OUTPUT @@ -109,7 +109,7 @@ jobs: # Update build.gradle with new version # macOS sed syntax - sed -i '' "s|implementation 'com\.onesignal:OneSignal:[^']*'|implementation 'com.onesignal:OneSignal:${VERSION}'|" android/build.gradle + sed -i '' -E "s|^def oneSignalVersion = ['\"][^'\"]*['\"]|def oneSignalVersion = '${VERSION}'|" android/build.gradle echo "✓ Updated android/build.gradle with Android SDK ${VERSION}" # Only commit if there are changes From 2f7b1ddf20f6d2b09bfe21fa3b985c81a7024dba Mon Sep 17 00:00:00 2001 From: Fadi George Date: Thu, 18 Jun 2026 11:16:11 -0700 Subject: [PATCH 2/2] ci: fix iOS version regex in release PR --- .github/workflows/create-release-pr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml index 4771a8f7..c45d76d5 100644 --- a/.github/workflows/create-release-pr.yml +++ b/.github/workflows/create-release-pr.yml @@ -86,7 +86,7 @@ jobs: # Get versions from target branch (not the release branch) CURRENT_VERSION=$(git show origin/${{ inputs.target_branch }}:pubspec.yaml | grep "^version:" | sed 's/version: //' | tr -d ' ') ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | sed -n "s/^def oneSignalVersion = ['\"]\([^'\"]*\)['\"].*/\1/p") - IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:ios/onesignal_flutter.podspec | sed -n "s/.*OneSignalXCFramework', '\([^']*\)'.*/\1/p") + IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:ios/onesignal_flutter.podspec | sed -n "s/^[[:space:]]*onesignal_xcframework_version = ['\"]\([^'\"]*\)['\"].*/\1/p") echo "flutter_from=$CURRENT_VERSION" >> $GITHUB_OUTPUT echo "android_from=$ANDROID_VERSION" >> $GITHUB_OUTPUT @@ -133,7 +133,7 @@ jobs: # Update onesignal_flutter.podspec with new version # macOS sed syntax - sed -i '' "s|s.dependency 'OneSignalXCFramework', '[^']*'|s.dependency 'OneSignalXCFramework', '${VERSION}'|" ios/onesignal_flutter.podspec + sed -i '' -E "s|^([[:space:]]*onesignal_xcframework_version = )['\"][^'\"]*['\"]|\\1'${VERSION}'|" ios/onesignal_flutter.podspec echo "✓ Updated ios/onesignal_flutter.podspec with iOS SDK ${VERSION}" # Update Package.swift with new version