[Feedback]: @types/node should be a devDependencies

[CHC383]

What's on your mind?

The Node typing is not explicitly used in the code, and should be a devDependencies to not be installed by the downstream consumers.

onesignal-node-api/package.json

Line 24 in cf1fc25

"@types/node": "^24.0.11",

Code of Conduct

• I agree to follow this project's Code of Conduct

[sherwinski]

The project uses certain types (like Buffer and URL) so we include the types as a runtime dependency for typescript compilation and type checking by library consumers.

I imagine something like this would happen if we were to remove it.

[CHC383]

Got it, I am using pnpm and @types/node: ^22.17.2, so it is automatically resolved/overridden to the version I specify, but I am not sure if it causes conflicts to other consumers with npm or yarn.

As @types/node should ideally match the Node version on the consumer side, maybe this should be changed to >=X or ^X || ^Y || ^Z. The minimum version is the Node version this SDK supports.

[sherwinski]

Yeah, that's a fair point. I'll have to look into backwards compatibility for those types and see if we can safely expand the permitted versions across @types/node.

[sherwinski]

This is now updated in v5.3.1-beta1 🚀