Skip to content

duplicated properties with non standard names #8

@jillesvangurp

Description

@jillesvangurp

several properties are being duplicated, example:

  • buildingId, building_id, and buildingIds
  • level_id and floorId
  • id and imdf_id
  • kind and feature_type (twice, once in the properties and once in the geojson feature) imdfType.

Action: Get rid of the non IMDF sanctioned properties (refer to the specification) and keep only one of these. Backwards compatibility is not a concern. Just remove support for these in the data models, don't parse them, etc. This affects all IMDF feature types.

{
  "type": "Feature",
  "id": "81634c5b-fa46-446e-8231-b91ada6a11ae",
  "feature_type": "level",
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [
          13.438875590938267,
          52.47962504431476
        ],
        [
          13.438854785893199,
          52.47967136522462
        ],
        [
          13.439488140959924,
          52.479783937112586
        ],
        [
          13.439658787847264,
          52.47943679130134
        ],
        [
          13.438742700472162,
          52.479269391818306
        ],
        [
          13.438673470095058,
          52.47939327742744
        ],
        [
          13.43868199265934,
          52.479394856572064
        ],
        [
          13.438659205732202,
          52.479440278554364
        ],
        [
          13.438625672843788,
          52.47943449532137
        ],
        [
          13.438559964193393,
          52.479568541494984
        ],
        [
          13.438875590938267,
          52.47962504431476
        ]
      ]
    ]
  },
  "properties": {
    "kind": "level",
    "imdfType": "level",
    "name": {
      "en": "Second Floor"
    },
    "short_name": {
      "en": "Second Floor"
    },
    "ordinal": 0,
    "outdoor": false,
    "level_id": "81634c5b-fa46-446e-8231-b91ada6a11ae",
    "floorId": "81634c5b-fa46-446e-8231-b91ada6a11ae",
    "building_ids": [
      "16572eee-bd58-47f2-9531-11f40a8a10fd"
    ],
    "feature_type": "level",
    "buildingId": "16572eee-bd58-47f2-9531-11f40a8a10fd",
    "building_id": "16572eee-bd58-47f2-9531-11f40a8a10fd",
    "id": "81634c5b-fa46-446e-8231-b91ada6a11ae",
    "imdf_id": "81634c5b-fa46-446e-8231-b91ada6a11ae",
    "__draw_line_color": "#dc2626"
  }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions