Skip to content

Refactor(architecture): Use Participants API/Models#155

Merged
RussellLuo merged 6 commits into
OpenCSGs:mainfrom
xxx7xxxx:dev
Jun 8, 2026
Merged

Refactor(architecture): Use Participants API/Models#155
RussellLuo merged 6 commits into
OpenCSGs:mainfrom
xxx7xxxx:dev

Conversation

@xxx7xxxx

@xxx7xxxx xxx7xxxx commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator
  • Refactor points
    • Introduce Participant as the channel-visible identity model, replacing public bot/user surfaces with /api/v1/channels/{channel}/participants APIs, CLI commands, and docs.
    • Rewire agent/runtime provisioning around participant IDs, including manager bootstrap recreation, PicoClaw/OpenClaw config/env, LLM bridge routes, and channel delivery paths.
    • Update the Web UI, embedded agent skills, API clients, and focused tests to use participant contracts while reducing legacy bot-command/API coverage.
    • Dependent PR: Refactor(architecture): Use Participants API/Models picoclaw#12
  • Test points:
    • All added cli like csgclaw participant/pt
    • Runtime: Codex, PicoClaw (without adapting/testing OpenClaw)
    • Channel CSGClaw (without adapting/testing FeiShu)

@xxx7xxxx xxx7xxxx requested review from GatewayJ and RussellLuo June 1, 2026 09:39
@GatewayJ

GatewayJ commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

CLI 没有足够定义,会有新命令么。新旧命令的迁移对照方案?

@xxx7xxxx

xxx7xxxx commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

@GatewayJ updated for cli

@xxx7xxxx xxx7xxxx marked this pull request as draft June 2, 2026 03:30
@xxx7xxxx

xxx7xxxx commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

And this PR is only for co-review so I've made it draft. Next step will be implementing Recreating Agent warning for outdated image with inheriting skills.

@xxx7xxxx xxx7xxxx force-pushed the dev branch 2 times, most recently from 08a1230 to f917389 Compare June 4, 2026 09:21
@xxx7xxxx xxx7xxxx marked this pull request as ready for review June 8, 2026 07:52
@xxx7xxxx xxx7xxxx changed the title Docs: Add participant architecture Refactor(architecture): Use Participants API/Models Jun 8, 2026
@xxx7xxxx

xxx7xxxx commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

@RussellLuo, ready to review.

Comment thread cli/csgclawcli/app.go
func (a *App) registerDefaultCommands() {
a.AddCommand(
bot.NewCmd(),
participantcmd.NewCmd(),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the existing bot config CLI entrypoint without introducing an equivalent replacement, even though /api/v1/channels/feishu/config is still supported server-side. That means existing Feishu configuration workflows will break on upgrade. If the plan is to move this under participant or channel semantics, it would be safer to add the replacement command first and only remove bot config after the migration path exists.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added csgclaw participant/pt config to replace bot config

@RussellLuo

Copy link
Copy Markdown
Collaborator

Follow-up idea for a future PR: after the participant migration settles, it may be worth fully retiring internal/bot and moving the remaining notification/compat responsibilities into the participant path as well. Right now the bot package still appears to carry notification delivery/config glue and some compatibility behavior, so the system is in a mixed bot/participant state. That is understandable for this transition, but finishing that consolidation later would reduce duplicate concepts and make the ownership boundaries much clearer.

@RussellLuo RussellLuo merged commit a4cfd35 into OpenCSGs:main Jun 8, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants