Skip to content

Commit 8788b5e

Browse files
committed
finished closing markups memory leaks from the framework's perspective
1 parent 65ef9a1 commit 8788b5e

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

src/component/Component.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -90,27 +90,21 @@ export default class Component {
9090
this.name = name ?? this.constructor.name;
9191

9292
this.emitter.once(this.EVENTS.rendered, (componentId) => {
93-
console.log("Component rendered:", componentId);
9493
let repo = container.resolve("repository");
9594
let component = repo.findComponent(componentId);
9695
if (component) component.rendered = true;
97-
console.log("Component rendered:", component);
9896
});
9997

10098
this.on(this.EVENTS.rerendered, (componentId) => {
101-
console.log("Component rerendered:", componentId);
10299
let repo = container.resolve("repository");
103100
let component = repo.findComponent(componentId);
104101
if (component) component.rerendered = true;
105-
console.log("Component rerendered:", component);
106102
});
107103

108104
this.on(this.EVENTS.mounted, (componentId) => {
109-
console.log("Component mounted:", componentId);
110105
let repo = container.resolve("repository");
111106
let component = repo.findComponent(componentId);
112107
if (component) component.handleMounted();
113-
console.log("Component mounted:", component);
114108
});
115109

116110
/**
@@ -447,8 +441,6 @@ export default class Component {
447441
return;
448442
}
449443

450-
let event = this.EVENTS.rendered;
451-
452444
if (
453445
parent &&
454446
(this.getValue(resetParent) || this.getValue(replaceParent))
@@ -458,13 +450,11 @@ export default class Component {
458450
let all = this.markup(parent);
459451
all.forEach((elem) => this.argsMap.delete(elem.getAttribute("uid")));
460452
}
461-
462-
if (this.argsMap.size) event = this.EVENTS.rerendered;
463453
}
464454

465455
let uuid = this.id;
466456

467-
this.argsMap.set(uuid, args ?? []);
457+
if(states?.length) this.argsMap.set(uuid, args ?? []);
468458

469459
let attr = {
470460
uid: uuid,

0 commit comments

Comments
 (0)