Skip to content

Commit c57782e

Browse files
fix: prevent Expanded Dark Theme inversion on scanner activity (#56)
* fix: prevent Expanded Dark Theme inversion on scanner activity Adds an AppCompat DayNight theme to `OSBARCScannerActivity` so Android does not treat it as a legacy light-themed app and invert its colors when Expanded Dark Theme is enabled. References: https://outsystemsrd.atlassian.net/browse/RMET-5280 * chore(release): prepare for version 2.0.2 Might be 2.1.0 instead if we bundle with #55; depends on merge order / time. * ci: comment failing Sonarcloud step Not being used these days, might as well comment to see if CI passes * docs: Remove unnecessary section from PR template * refactor: Change AppCompat to Material3 theme Following PR comment #56 (comment) * chore: revert to AppCompat due to apk size increase #56 (comment)
1 parent 9588a25 commit c57782e

7 files changed

Lines changed: 20 additions & 13 deletions

File tree

.github/workflows/run-unit-tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ jobs:
3434
- name: Setup sonarqube
3535
uses: warchant/setup-sonar-scanner@v8
3636

37-
- name: Send to Sonarcloud
38-
run: bundle exec fastlane sonarqube
39-
env:
40-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
41-
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
37+
#- name: Send to Sonarcloud
38+
# run: bundle exec fastlane sonarqube
39+
# env:
40+
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
41+
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
The changes documented here do not include those from the original repository.
88

9+
# [2.0.2]
10+
11+
### 2026-06-25
12+
13+
- Prevent Expanded Dark Theme inversion on scanner activity (https://outsystemsrd.atlassian.net/browse/RMET-5280)
14+
915
# [2.0.1]
1016

1117
### 2025-10-02

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ In your app-level gradle file, import the OSBarcodeLib library like so:
4646

4747
```gradle
4848
dependencies {
49-
implementation("com.github.outsystems:osbarcode-android:2.0.1@aar")
49+
implementation("com.github.outsystems:osbarcode-android:2.0.2@aar")
5050
}
5151
```
5252

docs/pull_request_template.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@
1212
- [ ] Refactor (cosmetic changes)
1313
- [ ] Breaking change (change that would cause existing functionality to not work as expected)
1414

15-
## Platforms affected
16-
- [ ] Android
17-
- [ ] iOS
18-
- [ ] JavaScript
19-
2015
## Tests
2116
<!--- Describe how you tested your changes in detail -->
2217
<!--- Include details of your test environment if relevant -->

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
<modelVersion>4.0.0</modelVersion>
88
<groupId>io.ionic.libs</groupId>
99
<artifactId>ionbarcode-android</artifactId>
10-
<version>2.0.1</version>
10+
<version>2.0.2</version>
1111
</project>

src/main/AndroidManifest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<application>
66
<activity
77
android:name=".view.OSBARCScannerActivity"
8-
android:exported="false" />
8+
android:exported="false"
9+
android:theme="@style/Theme.BarcodeScannerActivity" />
910
</application>
1011
</manifest>

src/main/res/values/themes.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<resources>
3+
<style name="Theme.BarcodeScannerActivity"
4+
parent="Theme.AppCompat.DayNight.NoActionBar" />
5+
</resources>

0 commit comments

Comments
 (0)