From bc17912726564e8615a3675a03c4c393c194c8cd Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Mon, 22 Jun 2026 00:12:27 +0200
Subject: [PATCH] PHP 8.4 polyfill: update false positive prevention

The PHP cross-version compatibility bug regarding the `Deprecated` attribute, which I previously reported to Symfony has been fixed.

This commit updates the ruleset to allow for the fix and prevent false positives on the new code introduced.

Refs:
* symfony/polyfill 551
* symfony/polyfill 556
---
 PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml b/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
index 083de97..6becd33 100644
--- a/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
+++ b/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
@@ -39,9 +39,11 @@
         <exclude-pattern>/polyfill-php84/Php84\.php$</exclude-pattern>
     </rule>
     <rule ref="PHPCompatibility.Attributes.NewAttributes.PHPNativeAttributeFound">
+        <exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
         <exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
     </rule>
     <rule ref="PHPCompatibility.Classes.NewClasses.attributeFound">
+        <exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
         <exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
     </rule>
     <rule ref="PHPCompatibility.FunctionUse.NewFunctions.get_debug_typeFound">
@@ -54,6 +56,7 @@
 
     <!-- This is fine as the autoloading for this file should only ever be triggered when on PHP 8.0 or higher. -->
     <rule ref="PHPCompatibility.Classes.NewTypedProperties.Found">
+        <exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
         <exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
     </rule>
 
@@ -74,13 +77,12 @@
         <exclude-pattern>/polyfill-php84/Php84\.php$</exclude-pattern>
     </rule>
 
-    <!--
-    Not a false positive, but a bug in the Symfony PHP 8.4 polyfill package.
-    Bug has been reported: https://github.com/symfony/polyfill/issues/551
-    Temporarily silencing the error as this needs to be solved upstream.
-    -->
+    <!-- See: https://github.com/symfony/polyfill/pull/556 -->
     <rule ref="PHPCompatibility.Classes.NewReadonlyProperties.Found">
+        <!-- Polyfill v1.30.0 - v1.33.0 -->
         <exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
+        <!-- Polyfill >= v1.34.0 -->
+        <exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
     </rule>
 
 </ruleset>