From 1006b3e291f757704f04b1e2aac146ce4d9fdac8 Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Mon, 22 Jun 2026 00:59:09 +0200
Subject: [PATCH] PHP 8.4 polyfill: update the ruleset for bc*() function /
 sync with v1.34.0

As of version v1.34.0, the BCMath `bcceil()`, `bcfloor()` and `bcround()` functions, as introduced in PHP 8.4, are now included in the Symfony polyfill.

Note: the upstream commit also polyfills the PHP `RoundingMode` enum, however, PHPCompatibility doesn't detect this yet, so this will need to be dealt with at a later point in time once it becomes clear how PHPCompatibility will report on this.
A test for the enum has been added to ensure that the tests for this package will start failing once PHPCompatibility addresses this.

Ref:
* symfony/polyfill 546
* https://github.com/symfony/polyfill/commit/7846989b4f2df4b38ee2e2cc2ead42b93ec100c0
---
 PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml | 8 ++++++++
 Test/SymfonyPolyfillPHP84Test.php                | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml b/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
index 6becd33..05b99e1 100644
--- a/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
+++ b/PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
@@ -17,7 +17,10 @@
         <exclude name="PHPCompatibility.FunctionUse.NewFunctions.mb_trimFound"/>
         <exclude name="PHPCompatibility.FunctionUse.NewFunctions.mb_ltrimFound"/>
         <exclude name="PHPCompatibility.FunctionUse.NewFunctions.mb_rtrimFound"/>
+        <exclude name="PHPCompatibility.FunctionUse.NewFunctions.bcceilFound"/>
         <exclude name="PHPCompatibility.FunctionUse.NewFunctions.bcdivmodFound"/>
+        <exclude name="PHPCompatibility.FunctionUse.NewFunctions.bcfloorFound"/>
+        <exclude name="PHPCompatibility.FunctionUse.NewFunctions.bcroundFound"/>
         <exclude name="PHPCompatibility.FunctionUse.NewFunctions.grapheme_str_splitFound"/>
 
         <!-- https://github.com/symfony/polyfill-php84/tree/1.x/Resources/stubs -->
@@ -68,6 +71,11 @@
         <exclude-pattern>/polyfill-php84/bootstrap82\.php$</exclude-pattern>
     </rule>
 
+    <!-- This is fine as this file will only be used for PHP 8.1 - 8.3. -->
+    <rule ref="PHPCompatibility.Keywords.NewKeywords.t_enumFound">
+        <exclude-pattern>/polyfill-php84/Resources/RoundingMode\.php$</exclude-pattern>
+    </rule>
+
     <!--
     Not a false positive, but a bug in the Symfony PHP 8.4 polyfill package.
     Bug has been reported: https://github.com/symfony/polyfill/issues/499#issuecomment-3430423298
diff --git a/Test/SymfonyPolyfillPHP84Test.php b/Test/SymfonyPolyfillPHP84Test.php
index 918713e..1780610 100644
--- a/Test/SymfonyPolyfillPHP84Test.php
+++ b/Test/SymfonyPolyfillPHP84Test.php
@@ -38,3 +38,7 @@ function doSomething(
 ) : Pdo\Odbc {}
 $db = new Pdo\Pgsql;
 $db = new \Pdo\Sqlite;
+
+bcceil($num);
+bcfloor($num);
+bcround($num, 2, RoundingMode::HalfAwayFromZero);