Fix nested ShouldProcess prompts; harden attachment-delete integration test

- Connect/Disconnect-Confluence: pass -Confirm:$false to the internal Set-ConfluenceConfig call so -Confirm does not raise a second nested confirmation prompt (review threads on Connect L136 / Disconnect L40).

- tests: use IsNullOrWhiteSpace for the integration skip guard so a whitespace-only CONFLUENCE_* variable is treated as missing (review thread on L113).

- tests: retry Remove-ConfluenceAttachment on transient HTTP 409 (conflict deleting attachment) to absorb Confluence Cloud eventual consistency; fixes the flaky Test-Confluence (Windows) CI failure.

Author: MariusStorhaug

src/functions/public/Auth/Connect-Confluence.ps1

@@ -133,7 +133,9 @@ function Connect-Confluence {
     }
 
     $stored = Set-Context -ID $Name -Context $context -Vault $script:Confluence.ContextVault -PassThru
-    Set-ConfluenceConfig -Name 'DefaultContext' -Value $Name
+    # The outer cmdlet already confirmed this operation; suppress the inner cmdlet's own
+    # ShouldProcess prompt so -Confirm does not trigger a second, nested confirmation.
+    Set-ConfluenceConfig -Name 'DefaultContext' -Value $Name -Confirm:$false
 
     if ($PassThru) {
         $stored

src/functions/public/Auth/Disconnect-Confluence.ps1

@@ -35,7 +35,9 @@ function Disconnect-Confluence {
     if ($PSCmdlet.ShouldProcess($Name, 'Remove Confluence credential context')) {
         Remove-Context -ID $Name -Vault $script:Confluence.ContextVault -ErrorAction SilentlyContinue
         if ($script:Confluence.Config['DefaultContext'] -eq $Name) {
-            Set-ConfluenceConfig -Name 'DefaultContext' -Value ''
+            # The outer cmdlet already confirmed this operation; suppress the inner cmdlet's
+            # ShouldProcess prompt so -Confirm does not trigger a second, nested confirmation.
+            Set-ConfluenceConfig -Name 'DefaultContext' -Value '' -Confirm:$false
         }
     }
 }

tests/Confluence.Tests.ps1

@@ -110,7 +110,7 @@ Describe 'Confluence' {
         $env:CONFLUENCE_SITE
         $env:CONFLUENCE_USERNAME
         $env:CONFLUENCE_SPACE_KEY
-    ) | Where-Object { [string]::IsNullOrEmpty($_) }
+    ) | Where-Object { [string]::IsNullOrWhiteSpace($_) }
 
     Context 'Integration' -Skip:(@($missingIntegrationVars).Count -gt 0) {
         BeforeAll {
@@ -671,7 +671,22 @@ Describe 'Confluence' {
             }
 
             It 'Remove-ConfluenceAttachment deletes the attachment' {
-                { Remove-ConfluenceAttachment -AttachmentId $script:attachmentId -Context 'ci' } | Should -Not -Throw
+                # Confluence Cloud can briefly return HTTP 409 ('Encountered conflict deleting
+                # attachment') when an attachment is removed shortly after it is uploaded, while
+                # the upload is still being reconciled server-side. Retry the delete so this
+                # eventual-consistency window does not fail the run; a non-conflict error, or a
+                # conflict that never clears, still surfaces and fails the test.
+                {
+                    for ($attempt = 1; $attempt -le 4; $attempt++) {
+                        try {
+                            Remove-ConfluenceAttachment -AttachmentId $script:attachmentId -Context 'ci'
+                            break
+                        } catch {
+                            if ($_.Exception.Message -notmatch 'HTTP 409|conflict' -or $attempt -eq 4) { throw }
+                            Start-Sleep -Seconds 2
+                        }
+                    }
+                } | Should -Not -Throw
                 LogGroup 'Attachments after removal' {
                     $remaining = Get-ConfluenceAttachment -PageId $script:attachPage.id -Context 'ci'
                     Write-Host ($remaining | Format-List | Out-String)