Skip to content

Commit 7eaddbb

Browse files
LocalIdentityLocalIdentity
andauthored
Fix some gems being hidden from gem list (#9796)
Using `fromItem` isn't going to work as the gem list gets mutated with it from many other places and it's too risky to change those Instead we now use a different tag that is untouched by anything else so it wont fail Tried looking in the game files to see if there was anything that'd show if the gems couldn't drop anymore and could not find anything so have to keep it hardcoded Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 99d458b commit 7eaddbb

3 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/Classes/GemSelectControl.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ function GemSelectClass:PopulateGemList()
109109
local characterLevel = self.skillsTab.build and self.skillsTab.build.characterLevel or 1
110110

111111
for gemId, gemData in pairs(self.skillsTab.build.data.gems) do
112-
if not gemData.grantedEffect.fromItem and (self.sortGemsBy and gemData.tags[self.sortGemsBy] == true or not self.sortGemsBy) then
112+
if not gemData.grantedEffect.hideFromGemList and (self.sortGemsBy and gemData.tags[self.sortGemsBy] == true or not self.sortGemsBy) then
113113
local levelRequirement = gemData.grantedEffect.levels[1].levelRequirement or 1
114114
if characterLevel >= levelRequirement or not matchLevel then
115115
if self.imbuedSelect then

src/Data/Skills/other.lua

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1212,6 +1212,7 @@ skills["SupportDivineBlessing"] = {
12121212
excludeSkillTypes = { SkillType.SummonsTotem, SkillType.InbuiltTrigger, },
12131213
statDescriptionScope = "gem_stat_descriptions",
12141214
fromItem = true,
1215+
hideFromGemList = true,
12151216
statMap = {
12161217
["support_aura_duration_base_buff_duration"] = {
12171218
skill("auraDuration", nil),
@@ -1385,6 +1386,7 @@ skills["SupportEarthbreaker"] = {
13851386
excludeSkillTypes = { SkillType.InbuiltTrigger, },
13861387
statDescriptionScope = "gem_stat_descriptions",
13871388
fromItem = true,
1389+
hideFromGemList = true,
13881390
addFlags = {
13891391
totem = true,
13901392
},

src/Export/Skills/other.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,7 @@ local skills, mod, flag, skill = ...
390390

391391
#skill SupportDivineBlessing
392392
fromItem = true,
393+
hideFromGemList = true,
393394
statMap = {
394395
["support_aura_duration_base_buff_duration"] = {
395396
skill("auraDuration", nil),
@@ -416,6 +417,7 @@ local skills, mod, flag, skill = ...
416417

417418
#skill SupportEarthbreaker
418419
fromItem = true,
420+
hideFromGemList = true,
419421
addFlags = {
420422
totem = true,
421423
},

0 commit comments

Comments
 (0)