From f25304dbab934c026ddf965a6d21c780420c1236 Mon Sep 17 00:00:00 2001 From: zyx <814780329@qq.com> Date: Fri, 17 Jul 2026 09:13:07 +0800 Subject: [PATCH] - redis.go: ping before set; fix panic message format - cache.go: remove redundant time.Second multiplication in Set expiration - cache.go: fix double pointer issue in json.Marshal/Unmarshal (use value, not &value) - redis_test.go: use Result() instead of Val() to handle errors properly - router.go: remove unnecessary return in AuthMiddleWare --- internal/cache/cache.go | 9 +++++---- internal/router/router.go | 6 +++--- utils/redis.go | 13 +++++++------ utils/redis_test.go | 5 +++-- 4 files changed, 18 insertions(+), 15 deletions(-) diff --git a/internal/cache/cache.go b/internal/cache/cache.go index 7f4c2dd..237d495 100755 --- a/internal/cache/cache.go +++ b/internal/cache/cache.go @@ -2,12 +2,13 @@ package cache import ( "encoding/json" - "golang.org/x/net/context" "time" "user_system/config" "user_system/internal/model" "user_system/pkg/constant" "user_system/utils" + + "golang.org/x/net/context" ) func GetUserInfoFromCache(username string) (*model.User, error) { @@ -28,7 +29,7 @@ func SetUserCacheInfo(user *model.User) error { return err } expired := time.Second * time.Duration(config.GetGlobalConf().Cache.UserExpired) - _, err = utils.GetRedisCli().Set(context.Background(), redisKey, val, expired*time.Second).Result() + _, err = utils.GetRedisCli().Set(context.Background(), redisKey, val, expired).Result() return err } @@ -48,13 +49,13 @@ func GetSessionInfo(session string) (*model.User, error) { return nil, err } user := &model.User{} - err = json.Unmarshal([]byte(val), &user) + err = json.Unmarshal([]byte(val), user) return user, err } func SetSessionInfo(user *model.User, session string) error { redisKey := constant.SessionKeyPrefix + session - val, err := json.Marshal(&user) + val, err := json.Marshal(user) if err != nil { return err } diff --git a/internal/router/router.go b/internal/router/router.go index 837f70f..e6f57cc 100755 --- a/internal/router/router.go +++ b/internal/router/router.go @@ -1,13 +1,14 @@ package router import ( - "github.com/gin-gonic/gin" - log "github.com/sirupsen/logrus" "net/http" "strconv" api "user_system/api/http/v1" "user_system/config" "user_system/pkg/constant" + + "github.com/gin-gonic/gin" + log "github.com/sirupsen/logrus" ) // InitRouterAndServe 路由配置、启动服务 @@ -58,6 +59,5 @@ func AuthMiddleWare() gin.HandlerFunc { // 返回错误 c.JSON(http.StatusUnauthorized, gin.H{"error": "err"}) c.Abort() - return } } diff --git a/utils/redis.go b/utils/redis.go index c926be2..95162e7 100755 --- a/utils/redis.go +++ b/utils/redis.go @@ -2,11 +2,12 @@ package utils import ( "fmt" + "sync" + "user_system/config" + "github.com/redis/go-redis/v9" log "github.com/sirupsen/logrus" "golang.org/x/net/context" - "sync" - "user_system/config" ) var ( @@ -28,12 +29,12 @@ func initRedis() { if redisConn == nil { panic("failed to call redis.NewClient") } - res, err := redisConn.Set(context.Background(), "abc", 100, 60).Result() - log.Infof("res=======%v,err======%v", res, err) - _, err = redisConn.Ping(context.Background()).Result() + _, err := redisConn.Ping(context.Background()).Result() if err != nil { - panic("Failed to ping redis, err:%s") + panic("Failed to ping redis, err:" + err.Error()) } + res, err := redisConn.Set(context.Background(), "abc", 100, 60).Result() + log.Infof("res=======%v,err======%v", res, err) } func CloseRedis() { diff --git a/utils/redis_test.go b/utils/redis_test.go index 0b6ee86..6c8d595 100644 --- a/utils/redis_test.go +++ b/utils/redis_test.go @@ -1,10 +1,11 @@ package utils import ( - "golang.org/x/net/context" "testing" "time" "user_system/config" + + "golang.org/x/net/context" ) func TestRedis(t *testing.T) { @@ -16,7 +17,7 @@ func TestRedis(t *testing.T) { } t.Logf("res=%s", res) - val := GetRedisCli().Get(ctx, "2222").Val() + val, err := GetRedisCli().Get(ctx, "2222").Result() if err != nil { t.Errorf("redis get err:%v", err) }