From 34c867a30cab602602510bd962bfe0756747a27f Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 10:48:24 +0200 Subject: [PATCH 1/9] refactor: external > unknown window --- DebuggingSpy/DSAbstractEventRecord.class.st | 3 ++- DebuggingSpy/DSToolInfo.class.st | 4 ++-- DebuggingSpy/DSWindowRecord.class.st | 8 +++++++- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/DebuggingSpy/DSAbstractEventRecord.class.st b/DebuggingSpy/DSAbstractEventRecord.class.st index 4278a34..039db49 100644 --- a/DebuggingSpy/DSAbstractEventRecord.class.st +++ b/DebuggingSpy/DSAbstractEventRecord.class.st @@ -124,5 +124,6 @@ DSAbstractEventRecord >> windowId: aWindowId [ { #category : 'accessing' } DSAbstractEventRecord >> windowType [ - ^'Unknown Window' + + ^ DSWindowRecord unknownWindow ] diff --git a/DebuggingSpy/DSToolInfo.class.st b/DebuggingSpy/DSToolInfo.class.st index 60ff75d..46c46eb 100644 --- a/DebuggingSpy/DSToolInfo.class.st +++ b/DebuggingSpy/DSToolInfo.class.st @@ -70,8 +70,8 @@ DSToolInfo >> windowIdentityHash: anObject [ { #category : 'accessing' } DSToolInfo >> windowType [ - "Returns the window type if the tool is known, and external window otherwise." + "Returns the window type if the tool is known, and unknown window otherwise." toolClass ifNotNil: [ ^ toolClass windowType ]. - ^ 'External Window' + ^ DSWindowRecord unknownWindow ] diff --git a/DebuggingSpy/DSWindowRecord.class.st b/DebuggingSpy/DSWindowRecord.class.st index 1d7a2ed..835ef6f 100644 --- a/DebuggingSpy/DSWindowRecord.class.st +++ b/DebuggingSpy/DSWindowRecord.class.st @@ -23,6 +23,12 @@ DSWindowRecord class >> for: events [ ^self new buildEvents: events ] +{ #category : 'accessing' } +DSWindowRecord class >> unknownWindow [ + + ^ 'Unknown Window' +] + { #category : 'accessing' } DSWindowRecord >> activePeriods [ @@ -170,5 +176,5 @@ DSWindowRecord >> windowNameFor: aDSWindowOpeningRecord [ DSWindowRecord >> windowType [ toolInfos ifNotNil: [ ^ toolInfos windowType ]. - ^ 'External Window' + ^ self class unknownWindow ] From 6a1b6fb3c91dc5d827a80420b1c183f6a62b001c Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 10:52:37 +0200 Subject: [PATCH 2/9] fix: DSWindowRecord tests --- DebuggingSpy-Tests/DSWindowRecordTest.class.st | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/DebuggingSpy-Tests/DSWindowRecordTest.class.st b/DebuggingSpy-Tests/DSWindowRecordTest.class.st index 7a0c04b..7736bb0 100644 --- a/DebuggingSpy-Tests/DSWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowRecordTest.class.st @@ -30,7 +30,7 @@ DSWindowRecordTest >> testBuildEvents [ self assert: windowRecord events size equals: 9. self assert: windowRecord name equals: 'Unknown window'. - self assert: windowRecord windowType equals: 'External Window'. + self assert: windowRecord windowType equals: 'Unknown Window'. self assert: windowRecord activePeriods size equals: 2. windowRecord := DSWindowRecord new toolInfo: (DSToolInfo new toolClass: StDebugger). @@ -113,11 +113,11 @@ DSWindowRecordTest >> testPrintOn [ windowRecord := DSWindowRecord new name: 'RandomName'. printed := String streamContents: [ :stream | windowRecord printOn: stream ]. - self assert: printed equals: '[External Window] RandomName'. + self assert: printed equals: '[Unknown Window] RandomName'. windowRecord := DSWindowRecord new name: DSWindowOpenedRecord. printed := String streamContents: [ :stream | windowRecord printOn: stream ]. - self assert: printed equals: '[External Window] DSWindowOpenedRecord' + self assert: printed equals: '[Unknown Window] DSWindowOpenedRecord' ] { #category : 'tests' } @@ -131,7 +131,7 @@ DSWindowRecordTest >> testPrintTypeOn [ windowRecord := DSWindowRecord new. printed := String streamContents: [ :stream | windowRecord printTypeOn: stream ]. - self assert: printed equals: 'External Window' + self assert: printed equals: 'Unknown Window' ] { #category : 'tests' } @@ -192,5 +192,5 @@ DSWindowRecordTest >> testWindowType [ self assert: windowRecord windowType equals: 'Debugger'. windowRecord toolInfo: DSToolInfo new. - self assert: windowRecord windowType equals: 'External Window' + self assert: windowRecord windowType equals: 'Unknown Window' ] From 2fc4af5dd3f0a750fd09f98df50378bfb3bdca77 Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 11:28:10 +0200 Subject: [PATCH 3/9] feat: print using toolInfo --- .../DebugPointBrowserPresenter.extension.st | 2 +- DebuggingSpy-Browser/Object.extension.st | 2 +- ...ritiquePackageSelectorPresenter.extension.st | 2 +- .../DSAbstractEventRecordTest.class.st | 6 ++++++ .../DSMouseEnterWindowRecordTest.class.st | 17 +++++++++++++++++ .../DSMouseEventRecordTest.class.st | 6 ++++++ .../DSMouseLeaveWindowRecordTest.class.st | 17 +++++++++++++++++ .../DSWindowActivatedRecordTest.class.st | 17 +++++++++++++++++ .../DSWindowClosedRecordTest.class.st | 17 +++++++++++++++++ .../DSWindowEventRecordTest.class.st | 6 ++++++ .../DSWindowOpenedRecordTest.class.st | 17 +++++++++++++++++ DebuggingSpy-Tests/DSWindowRecordTest.class.st | 2 +- DebuggingSpy/DSMouseEnterWindowRecord.class.st | 4 +++- DebuggingSpy/DSMouseLeaveWindowRecord.class.st | 4 +++- DebuggingSpy/DSWindowActivatedRecord.class.st | 4 +++- DebuggingSpy/DSWindowClosedRecord.class.st | 4 +++- DebuggingSpy/DSWindowEventRecord.class.st | 2 +- DebuggingSpy/DSWindowOpenedRecord.class.st | 4 +++- 18 files changed, 123 insertions(+), 10 deletions(-) create mode 100644 DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSMouseEventRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowEventRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st diff --git a/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st b/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st index 122134e..a467048 100644 --- a/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st +++ b/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st @@ -10,5 +10,5 @@ DebugPointBrowserPresenter class >> windowColor [ { #category : '*DebuggingSpy-Browser' } DebugPointBrowserPresenter class >> windowType [ - ^ 'Debug point browser' + ^ 'Debug Point Browser' ] diff --git a/DebuggingSpy-Browser/Object.extension.st b/DebuggingSpy-Browser/Object.extension.st index 62b22cf..614d4a2 100644 --- a/DebuggingSpy-Browser/Object.extension.st +++ b/DebuggingSpy-Browser/Object.extension.st @@ -12,5 +12,5 @@ Object class >> windowColor [ Object class >> windowType [ "Returns the name of the window type." - ^ 'Unknown window' + ^ DSWindowRecord unknownWindow ] diff --git a/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st b/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st index c21d065..a655295 100644 --- a/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st +++ b/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st @@ -10,5 +10,5 @@ StCritiquePackageSelectorPresenter class >> windowColor [ { #category : '*DebuggingSpy-Browser' } StCritiquePackageSelectorPresenter class >> windowType [ - ^ 'Critique browser' + ^ 'Critique Browser' ] diff --git a/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st b/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st new file mode 100644 index 0000000..8b73fb4 --- /dev/null +++ b/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st @@ -0,0 +1,6 @@ +Class { + #name : 'DSAbstractEventRecordTest', + #superclass : 'TestCase', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} diff --git a/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st new file mode 100644 index 0000000..1f89bdb --- /dev/null +++ b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSMouseEnterWindowRecordTest', + #superclass : 'DSMouseEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSMouseEnterWindowRecordTest >> testEventName [ + + | record | + record := DSMouseEnterWindowRecord new. + self assert: record eventName equals: 'Enter Unknown Window'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Enter Debugger' +] diff --git a/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st new file mode 100644 index 0000000..deae1ff --- /dev/null +++ b/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st @@ -0,0 +1,6 @@ +Class { + #name : 'DSMouseEventRecordTest', + #superclass : 'DSAbstractEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} diff --git a/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st new file mode 100644 index 0000000..335d32b --- /dev/null +++ b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSMouseLeaveWindowRecordTest', + #superclass : 'DSMouseEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSMouseLeaveWindowRecordTest >> testEventName [ + + | record | + record := DSMouseLeaveWindowRecord new. + self assert: record eventName equals: 'Leave Unknown Window'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Leave Debugger' +] diff --git a/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st new file mode 100644 index 0000000..efc8ecf --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSWindowActivatedRecordTest', + #superclass : 'DSWindowEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSWindowActivatedRecordTest >> testEventName [ + + | record | + record := DSWindowActivatedRecord new. + self assert: record eventName equals: 'Unknown Window activated'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Debugger activated' +] diff --git a/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st new file mode 100644 index 0000000..16bcc31 --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSWindowClosedRecordTest', + #superclass : 'DSWindowEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSWindowClosedRecordTest >> testEventName [ + + | record | + record := DSWindowClosedRecord new. + self assert: record eventName equals: 'Unknown Window closed'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Debugger closed' +] diff --git a/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st b/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st new file mode 100644 index 0000000..2d33d12 --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st @@ -0,0 +1,6 @@ +Class { + #name : 'DSWindowEventRecordTest', + #superclass : 'DSAbstractEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} diff --git a/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st new file mode 100644 index 0000000..1dbfcf6 --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSWindowOpenedRecordTest', + #superclass : 'DSWindowEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSWindowOpenedRecordTest >> testEventName [ + + | record | + record := DSWindowOpenedRecord new. + self assert: record eventName equals: 'Unknown Window opened'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Debugger opened' +] diff --git a/DebuggingSpy-Tests/DSWindowRecordTest.class.st b/DebuggingSpy-Tests/DSWindowRecordTest.class.st index 7736bb0..95f6b8a 100644 --- a/DebuggingSpy-Tests/DSWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowRecordTest.class.st @@ -14,7 +14,7 @@ DSWindowRecordTest >> testBuildEvents [ eventsCollection := { (DSWindowOpenedRecord new - windowName: 'Unknown window'; + windowName: 'Unknown Window'; windowId: 42; dateTime: '2008-01-22T16:00:25' asDateAndTime). (DSMouseEnterWindowRecord new dateTime: '2008-01-22T16:00:31' asDateAndTime). diff --git a/DebuggingSpy/DSMouseEnterWindowRecord.class.st b/DebuggingSpy/DSMouseEnterWindowRecord.class.st index e44ec43..d1a8556 100644 --- a/DebuggingSpy/DSMouseEnterWindowRecord.class.st +++ b/DebuggingSpy/DSMouseEnterWindowRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSMouseEnterWindowRecord >> eventName [ - ^'Enter window' + + toolInfo ifNil: [ ^ 'Enter ' , DSWindowRecord unknownWindow ]. + ^ 'Enter ' , toolInfo windowType ] diff --git a/DebuggingSpy/DSMouseLeaveWindowRecord.class.st b/DebuggingSpy/DSMouseLeaveWindowRecord.class.st index 86ec96d..24814d2 100644 --- a/DebuggingSpy/DSMouseLeaveWindowRecord.class.st +++ b/DebuggingSpy/DSMouseLeaveWindowRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSMouseLeaveWindowRecord >> eventName [ - ^'Leave window' + + toolInfo ifNil: [ ^ 'Leave ' , DSWindowRecord unknownWindow ]. + ^ 'Leave ' , toolInfo windowType ] diff --git a/DebuggingSpy/DSWindowActivatedRecord.class.st b/DebuggingSpy/DSWindowActivatedRecord.class.st index dcf6a2e..8c79223 100644 --- a/DebuggingSpy/DSWindowActivatedRecord.class.st +++ b/DebuggingSpy/DSWindowActivatedRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSWindowActivatedRecord >> eventName [ - ^'Window activated' + + toolInfo ifNil: [ ^ DSWindowRecord unknownWindow , ' activated' ]. + ^ toolInfo windowType , ' activated' ] diff --git a/DebuggingSpy/DSWindowClosedRecord.class.st b/DebuggingSpy/DSWindowClosedRecord.class.st index beb366f..ec4d752 100644 --- a/DebuggingSpy/DSWindowClosedRecord.class.st +++ b/DebuggingSpy/DSWindowClosedRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSWindowClosedRecord >> eventName [ - ^'Window closed' + + toolInfo ifNil: [ ^ DSWindowRecord unknownWindow , ' closed' ]. + ^ toolInfo windowType , ' closed' ] diff --git a/DebuggingSpy/DSWindowEventRecord.class.st b/DebuggingSpy/DSWindowEventRecord.class.st index 8f24968..61e179f 100644 --- a/DebuggingSpy/DSWindowEventRecord.class.st +++ b/DebuggingSpy/DSWindowEventRecord.class.st @@ -31,7 +31,7 @@ DSWindowEventRecord >> recordWindowNameFromEvent: anEvent [ windowName := [ anEvent window label ] on: Error - do: [ 'Unknown window' ] + do: [ DSWindowRecord unknownWindow ] ] { #category : 'comparing' } diff --git a/DebuggingSpy/DSWindowOpenedRecord.class.st b/DebuggingSpy/DSWindowOpenedRecord.class.st index c013de7..4162ba1 100644 --- a/DebuggingSpy/DSWindowOpenedRecord.class.st +++ b/DebuggingSpy/DSWindowOpenedRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSWindowOpenedRecord >> eventName [ - ^'Window opened' + + toolInfo ifNil: [ ^ DSWindowRecord unknownWindow , ' opened' ]. + ^ toolInfo windowType , ' opened' ] From 12205d1ad08189472ada98d03427f2c8ddc8fd88 Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 10:48:24 +0200 Subject: [PATCH 4/9] refactor: external > unknown window --- DebuggingSpy/DSAbstractEventRecord.class.st | 3 ++- DebuggingSpy/DSToolInfo.class.st | 4 ++-- DebuggingSpy/DSWindowRecord.class.st | 8 +++++++- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/DebuggingSpy/DSAbstractEventRecord.class.st b/DebuggingSpy/DSAbstractEventRecord.class.st index 4278a34..039db49 100644 --- a/DebuggingSpy/DSAbstractEventRecord.class.st +++ b/DebuggingSpy/DSAbstractEventRecord.class.st @@ -124,5 +124,6 @@ DSAbstractEventRecord >> windowId: aWindowId [ { #category : 'accessing' } DSAbstractEventRecord >> windowType [ - ^'Unknown Window' + + ^ DSWindowRecord unknownWindow ] diff --git a/DebuggingSpy/DSToolInfo.class.st b/DebuggingSpy/DSToolInfo.class.st index 60ff75d..46c46eb 100644 --- a/DebuggingSpy/DSToolInfo.class.st +++ b/DebuggingSpy/DSToolInfo.class.st @@ -70,8 +70,8 @@ DSToolInfo >> windowIdentityHash: anObject [ { #category : 'accessing' } DSToolInfo >> windowType [ - "Returns the window type if the tool is known, and external window otherwise." + "Returns the window type if the tool is known, and unknown window otherwise." toolClass ifNotNil: [ ^ toolClass windowType ]. - ^ 'External Window' + ^ DSWindowRecord unknownWindow ] diff --git a/DebuggingSpy/DSWindowRecord.class.st b/DebuggingSpy/DSWindowRecord.class.st index 1d7a2ed..835ef6f 100644 --- a/DebuggingSpy/DSWindowRecord.class.st +++ b/DebuggingSpy/DSWindowRecord.class.st @@ -23,6 +23,12 @@ DSWindowRecord class >> for: events [ ^self new buildEvents: events ] +{ #category : 'accessing' } +DSWindowRecord class >> unknownWindow [ + + ^ 'Unknown Window' +] + { #category : 'accessing' } DSWindowRecord >> activePeriods [ @@ -170,5 +176,5 @@ DSWindowRecord >> windowNameFor: aDSWindowOpeningRecord [ DSWindowRecord >> windowType [ toolInfos ifNotNil: [ ^ toolInfos windowType ]. - ^ 'External Window' + ^ self class unknownWindow ] From 8e89cc759ca8fb3c26815a90f365994adfafd17b Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 10:52:37 +0200 Subject: [PATCH 5/9] fix: DSWindowRecord tests --- DebuggingSpy-Tests/DSWindowRecordTest.class.st | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/DebuggingSpy-Tests/DSWindowRecordTest.class.st b/DebuggingSpy-Tests/DSWindowRecordTest.class.st index 7a0c04b..7736bb0 100644 --- a/DebuggingSpy-Tests/DSWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowRecordTest.class.st @@ -30,7 +30,7 @@ DSWindowRecordTest >> testBuildEvents [ self assert: windowRecord events size equals: 9. self assert: windowRecord name equals: 'Unknown window'. - self assert: windowRecord windowType equals: 'External Window'. + self assert: windowRecord windowType equals: 'Unknown Window'. self assert: windowRecord activePeriods size equals: 2. windowRecord := DSWindowRecord new toolInfo: (DSToolInfo new toolClass: StDebugger). @@ -113,11 +113,11 @@ DSWindowRecordTest >> testPrintOn [ windowRecord := DSWindowRecord new name: 'RandomName'. printed := String streamContents: [ :stream | windowRecord printOn: stream ]. - self assert: printed equals: '[External Window] RandomName'. + self assert: printed equals: '[Unknown Window] RandomName'. windowRecord := DSWindowRecord new name: DSWindowOpenedRecord. printed := String streamContents: [ :stream | windowRecord printOn: stream ]. - self assert: printed equals: '[External Window] DSWindowOpenedRecord' + self assert: printed equals: '[Unknown Window] DSWindowOpenedRecord' ] { #category : 'tests' } @@ -131,7 +131,7 @@ DSWindowRecordTest >> testPrintTypeOn [ windowRecord := DSWindowRecord new. printed := String streamContents: [ :stream | windowRecord printTypeOn: stream ]. - self assert: printed equals: 'External Window' + self assert: printed equals: 'Unknown Window' ] { #category : 'tests' } @@ -192,5 +192,5 @@ DSWindowRecordTest >> testWindowType [ self assert: windowRecord windowType equals: 'Debugger'. windowRecord toolInfo: DSToolInfo new. - self assert: windowRecord windowType equals: 'External Window' + self assert: windowRecord windowType equals: 'Unknown Window' ] From cd827e696c432537893931e9e9811216609811e4 Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 11:28:10 +0200 Subject: [PATCH 6/9] feat: print using toolInfo --- .../DebugPointBrowserPresenter.extension.st | 2 +- DebuggingSpy-Browser/Object.extension.st | 2 +- ...ritiquePackageSelectorPresenter.extension.st | 2 +- .../DSAbstractEventRecordTest.class.st | 6 ++++++ .../DSMouseEnterWindowRecordTest.class.st | 17 +++++++++++++++++ .../DSMouseEventRecordTest.class.st | 6 ++++++ .../DSMouseLeaveWindowRecordTest.class.st | 17 +++++++++++++++++ .../DSWindowActivatedRecordTest.class.st | 17 +++++++++++++++++ .../DSWindowClosedRecordTest.class.st | 17 +++++++++++++++++ .../DSWindowEventRecordTest.class.st | 6 ++++++ .../DSWindowOpenedRecordTest.class.st | 17 +++++++++++++++++ DebuggingSpy-Tests/DSWindowRecordTest.class.st | 2 +- DebuggingSpy/DSMouseEnterWindowRecord.class.st | 4 +++- DebuggingSpy/DSMouseLeaveWindowRecord.class.st | 4 +++- DebuggingSpy/DSWindowActivatedRecord.class.st | 4 +++- DebuggingSpy/DSWindowClosedRecord.class.st | 4 +++- DebuggingSpy/DSWindowEventRecord.class.st | 2 +- DebuggingSpy/DSWindowOpenedRecord.class.st | 4 +++- 18 files changed, 123 insertions(+), 10 deletions(-) create mode 100644 DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSMouseEventRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowEventRecordTest.class.st create mode 100644 DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st diff --git a/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st b/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st index 7ccb3a1..776b8fa 100644 --- a/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st +++ b/DebuggingSpy-Browser/DebugPointBrowserPresenter.extension.st @@ -10,5 +10,5 @@ DebugPointBrowserPresenter class >> windowColor [ { #category : '*DebuggingSpy-Browser' } DebugPointBrowserPresenter class >> windowType [ - ^ 'Debug point browser' + ^ 'Debug Point Browser' ] diff --git a/DebuggingSpy-Browser/Object.extension.st b/DebuggingSpy-Browser/Object.extension.st index 62b22cf..614d4a2 100644 --- a/DebuggingSpy-Browser/Object.extension.st +++ b/DebuggingSpy-Browser/Object.extension.st @@ -12,5 +12,5 @@ Object class >> windowColor [ Object class >> windowType [ "Returns the name of the window type." - ^ 'Unknown window' + ^ DSWindowRecord unknownWindow ] diff --git a/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st b/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st index 976836d..a1667df 100644 --- a/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st +++ b/DebuggingSpy-Browser/StCritiquePackageSelectorPresenter.extension.st @@ -10,5 +10,5 @@ StCritiquePackageSelectorPresenter class >> windowColor [ { #category : '*DebuggingSpy-Browser' } StCritiquePackageSelectorPresenter class >> windowType [ - ^ 'Critique browser' + ^ 'Critique Browser' ] diff --git a/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st b/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st new file mode 100644 index 0000000..8b73fb4 --- /dev/null +++ b/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st @@ -0,0 +1,6 @@ +Class { + #name : 'DSAbstractEventRecordTest', + #superclass : 'TestCase', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} diff --git a/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st new file mode 100644 index 0000000..1f89bdb --- /dev/null +++ b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSMouseEnterWindowRecordTest', + #superclass : 'DSMouseEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSMouseEnterWindowRecordTest >> testEventName [ + + | record | + record := DSMouseEnterWindowRecord new. + self assert: record eventName equals: 'Enter Unknown Window'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Enter Debugger' +] diff --git a/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st new file mode 100644 index 0000000..deae1ff --- /dev/null +++ b/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st @@ -0,0 +1,6 @@ +Class { + #name : 'DSMouseEventRecordTest', + #superclass : 'DSAbstractEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} diff --git a/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st new file mode 100644 index 0000000..335d32b --- /dev/null +++ b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSMouseLeaveWindowRecordTest', + #superclass : 'DSMouseEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSMouseLeaveWindowRecordTest >> testEventName [ + + | record | + record := DSMouseLeaveWindowRecord new. + self assert: record eventName equals: 'Leave Unknown Window'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Leave Debugger' +] diff --git a/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st new file mode 100644 index 0000000..efc8ecf --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSWindowActivatedRecordTest', + #superclass : 'DSWindowEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSWindowActivatedRecordTest >> testEventName [ + + | record | + record := DSWindowActivatedRecord new. + self assert: record eventName equals: 'Unknown Window activated'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Debugger activated' +] diff --git a/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st new file mode 100644 index 0000000..16bcc31 --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSWindowClosedRecordTest', + #superclass : 'DSWindowEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSWindowClosedRecordTest >> testEventName [ + + | record | + record := DSWindowClosedRecord new. + self assert: record eventName equals: 'Unknown Window closed'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Debugger closed' +] diff --git a/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st b/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st new file mode 100644 index 0000000..2d33d12 --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st @@ -0,0 +1,6 @@ +Class { + #name : 'DSWindowEventRecordTest', + #superclass : 'DSAbstractEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} diff --git a/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st new file mode 100644 index 0000000..1dbfcf6 --- /dev/null +++ b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st @@ -0,0 +1,17 @@ +Class { + #name : 'DSWindowOpenedRecordTest', + #superclass : 'DSWindowEventRecordTest', + #category : 'DebuggingSpy-Tests', + #package : 'DebuggingSpy-Tests' +} + +{ #category : 'tests' } +DSWindowOpenedRecordTest >> testEventName [ + + | record | + record := DSWindowOpenedRecord new. + self assert: record eventName equals: 'Unknown Window opened'. + + record toolInfo: (DSToolInfo new toolClass: StDebugger). + self assert: record eventName equals: 'Debugger opened' +] diff --git a/DebuggingSpy-Tests/DSWindowRecordTest.class.st b/DebuggingSpy-Tests/DSWindowRecordTest.class.st index 7736bb0..95f6b8a 100644 --- a/DebuggingSpy-Tests/DSWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowRecordTest.class.st @@ -14,7 +14,7 @@ DSWindowRecordTest >> testBuildEvents [ eventsCollection := { (DSWindowOpenedRecord new - windowName: 'Unknown window'; + windowName: 'Unknown Window'; windowId: 42; dateTime: '2008-01-22T16:00:25' asDateAndTime). (DSMouseEnterWindowRecord new dateTime: '2008-01-22T16:00:31' asDateAndTime). diff --git a/DebuggingSpy/DSMouseEnterWindowRecord.class.st b/DebuggingSpy/DSMouseEnterWindowRecord.class.st index e44ec43..d1a8556 100644 --- a/DebuggingSpy/DSMouseEnterWindowRecord.class.st +++ b/DebuggingSpy/DSMouseEnterWindowRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSMouseEnterWindowRecord >> eventName [ - ^'Enter window' + + toolInfo ifNil: [ ^ 'Enter ' , DSWindowRecord unknownWindow ]. + ^ 'Enter ' , toolInfo windowType ] diff --git a/DebuggingSpy/DSMouseLeaveWindowRecord.class.st b/DebuggingSpy/DSMouseLeaveWindowRecord.class.st index 86ec96d..24814d2 100644 --- a/DebuggingSpy/DSMouseLeaveWindowRecord.class.st +++ b/DebuggingSpy/DSMouseLeaveWindowRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSMouseLeaveWindowRecord >> eventName [ - ^'Leave window' + + toolInfo ifNil: [ ^ 'Leave ' , DSWindowRecord unknownWindow ]. + ^ 'Leave ' , toolInfo windowType ] diff --git a/DebuggingSpy/DSWindowActivatedRecord.class.st b/DebuggingSpy/DSWindowActivatedRecord.class.st index dcf6a2e..8c79223 100644 --- a/DebuggingSpy/DSWindowActivatedRecord.class.st +++ b/DebuggingSpy/DSWindowActivatedRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSWindowActivatedRecord >> eventName [ - ^'Window activated' + + toolInfo ifNil: [ ^ DSWindowRecord unknownWindow , ' activated' ]. + ^ toolInfo windowType , ' activated' ] diff --git a/DebuggingSpy/DSWindowClosedRecord.class.st b/DebuggingSpy/DSWindowClosedRecord.class.st index beb366f..ec4d752 100644 --- a/DebuggingSpy/DSWindowClosedRecord.class.st +++ b/DebuggingSpy/DSWindowClosedRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSWindowClosedRecord >> eventName [ - ^'Window closed' + + toolInfo ifNil: [ ^ DSWindowRecord unknownWindow , ' closed' ]. + ^ toolInfo windowType , ' closed' ] diff --git a/DebuggingSpy/DSWindowEventRecord.class.st b/DebuggingSpy/DSWindowEventRecord.class.st index 8f24968..61e179f 100644 --- a/DebuggingSpy/DSWindowEventRecord.class.st +++ b/DebuggingSpy/DSWindowEventRecord.class.st @@ -31,7 +31,7 @@ DSWindowEventRecord >> recordWindowNameFromEvent: anEvent [ windowName := [ anEvent window label ] on: Error - do: [ 'Unknown window' ] + do: [ DSWindowRecord unknownWindow ] ] { #category : 'comparing' } diff --git a/DebuggingSpy/DSWindowOpenedRecord.class.st b/DebuggingSpy/DSWindowOpenedRecord.class.st index c013de7..4162ba1 100644 --- a/DebuggingSpy/DSWindowOpenedRecord.class.st +++ b/DebuggingSpy/DSWindowOpenedRecord.class.st @@ -11,5 +11,7 @@ Class { { #category : 'accessing' } DSWindowOpenedRecord >> eventName [ - ^'Window opened' + + toolInfo ifNil: [ ^ DSWindowRecord unknownWindow , ' opened' ]. + ^ toolInfo windowType , ' opened' ] From 57d20ee0b16c2709dade79b755c10c2e500b5476 Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 14:17:44 +0200 Subject: [PATCH 7/9] test: fixes and refactoring --- .../DSRecordBrowserPresenterTest.class.st | 10 +++++----- DebuggingSpy-Browser-Tests/DSTimerWindowTest.class.st | 2 +- DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st | 6 ------ .../DSMouseEnterWindowRecordTest.class.st | 2 +- DebuggingSpy-Tests/DSMouseEventRecordTest.class.st | 6 ------ .../DSMouseLeaveWindowRecordTest.class.st | 2 +- .../DSWindowActivatedRecordTest.class.st | 2 +- DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st | 2 +- DebuggingSpy-Tests/DSWindowEventRecordTest.class.st | 6 ------ DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st | 2 +- DebuggingSpy-Tests/DSWindowRecordTest.class.st | 2 +- 11 files changed, 12 insertions(+), 30 deletions(-) delete mode 100644 DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st delete mode 100644 DebuggingSpy-Tests/DSMouseEventRecordTest.class.st delete mode 100644 DebuggingSpy-Tests/DSWindowEventRecordTest.class.st diff --git a/DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st b/DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st index cd701a2..411065c 100644 --- a/DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st +++ b/DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st @@ -164,19 +164,19 @@ DSRecordBrowserPresenterTest >> testColorAssociations [ | associations | associations := { ((Color fromHexString: '#1f48ff') -> 'Browser'). - ((Color fromHexString: '#772980') -> 'Debug point browser'). + ((Color fromHexString: '#772980') -> 'Debug Point Browser'). ((Color fromHexString: '#345e54') -> 'Epicea'). ((Color fromHexString: '#00e5ff') -> 'Iceberg'). - ((Color fromHexString: '#ff9100') -> 'Critique browser'). + ((Color fromHexString: '#ff9100') -> 'Critique Browser'). ((Color fromHexString: '#ff2200') -> 'Debugger'). ((Color fromHexString: '#fad314') -> 'Inspector'). ((Color fromHexString: '#70B77E') -> 'Playground'). - ((Color fromHexString: '#ffffff') -> 'Rewriter'). + (Color white -> 'Rewriter'). ((Color fromHexString: '#ec45ff') -> 'Debugging Spy'). - ((Color fromHexString: '#b3b3b3') -> 'Unknown window') }. + ((Color fromHexString: '#b3b3b3') -> 'Unknown Window') }. self assert: associations size equals: DSRecordBrowserPresenter colorAssociations size. - self assert: (associations allSatisfy: [ :asso | DSRecordBrowserPresenter colorAssociations includes: asso ]) + associations do: [ :asso | self assert: (DSRecordBrowserPresenter colorAssociations includes: asso) ] ] { #category : 'tests' } diff --git a/DebuggingSpy-Browser-Tests/DSTimerWindowTest.class.st b/DebuggingSpy-Browser-Tests/DSTimerWindowTest.class.st index 305d421..cca2af6 100644 --- a/DebuggingSpy-Browser-Tests/DSTimerWindowTest.class.st +++ b/DebuggingSpy-Browser-Tests/DSTimerWindowTest.class.st @@ -74,7 +74,7 @@ DSTimerWindowTest >> testGetFormattedNameFrom [ self assert: (timerWindow getFormattedNameFrom: DSBrowseRecord new) equals: 'Browse'. self assert: (timerWindow getFormattedNameFrom: (DSMouseEnterWindowRecord new toolInfo: toolInfo)) - equals: 'Enter window (DSTimerWindowTest)'. + equals: 'Enter Unknown Window (DSTimerWindowTest)'. self assert: (timerWindow getFormattedNameFrom: DSBrowseRecord new) equals: 'Browse (DSTimerWindowTest)' ] diff --git a/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st b/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st deleted file mode 100644 index 8b73fb4..0000000 --- a/DebuggingSpy-Tests/DSAbstractEventRecordTest.class.st +++ /dev/null @@ -1,6 +0,0 @@ -Class { - #name : 'DSAbstractEventRecordTest', - #superclass : 'TestCase', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' -} diff --git a/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st index 1f89bdb..34f4ac1 100644 --- a/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st @@ -1,6 +1,6 @@ Class { #name : 'DSMouseEnterWindowRecordTest', - #superclass : 'DSMouseEventRecordTest', + #superclass : 'TestCase', #category : 'DebuggingSpy-Tests', #package : 'DebuggingSpy-Tests' } diff --git a/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st deleted file mode 100644 index deae1ff..0000000 --- a/DebuggingSpy-Tests/DSMouseEventRecordTest.class.st +++ /dev/null @@ -1,6 +0,0 @@ -Class { - #name : 'DSMouseEventRecordTest', - #superclass : 'DSAbstractEventRecordTest', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' -} diff --git a/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st index 335d32b..47660fb 100644 --- a/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st @@ -1,6 +1,6 @@ Class { #name : 'DSMouseLeaveWindowRecordTest', - #superclass : 'DSMouseEventRecordTest', + #superclass : 'TestCase', #category : 'DebuggingSpy-Tests', #package : 'DebuggingSpy-Tests' } diff --git a/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st index efc8ecf..40eaed2 100644 --- a/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st @@ -1,6 +1,6 @@ Class { #name : 'DSWindowActivatedRecordTest', - #superclass : 'DSWindowEventRecordTest', + #superclass : 'TestCase', #category : 'DebuggingSpy-Tests', #package : 'DebuggingSpy-Tests' } diff --git a/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st index 16bcc31..2731247 100644 --- a/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st @@ -1,6 +1,6 @@ Class { #name : 'DSWindowClosedRecordTest', - #superclass : 'DSWindowEventRecordTest', + #superclass : 'TestCase', #category : 'DebuggingSpy-Tests', #package : 'DebuggingSpy-Tests' } diff --git a/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st b/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st deleted file mode 100644 index 2d33d12..0000000 --- a/DebuggingSpy-Tests/DSWindowEventRecordTest.class.st +++ /dev/null @@ -1,6 +0,0 @@ -Class { - #name : 'DSWindowEventRecordTest', - #superclass : 'DSAbstractEventRecordTest', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' -} diff --git a/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st index 1dbfcf6..8c1e781 100644 --- a/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st @@ -1,6 +1,6 @@ Class { #name : 'DSWindowOpenedRecordTest', - #superclass : 'DSWindowEventRecordTest', + #superclass : 'TestCase', #category : 'DebuggingSpy-Tests', #package : 'DebuggingSpy-Tests' } diff --git a/DebuggingSpy-Tests/DSWindowRecordTest.class.st b/DebuggingSpy-Tests/DSWindowRecordTest.class.st index 95f6b8a..465383e 100644 --- a/DebuggingSpy-Tests/DSWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowRecordTest.class.st @@ -29,7 +29,7 @@ DSWindowRecordTest >> testBuildEvents [ windowRecord buildEvents: eventsCollection. self assert: windowRecord events size equals: 9. - self assert: windowRecord name equals: 'Unknown window'. + self assert: windowRecord name equals: 'Unknown Window'. self assert: windowRecord windowType equals: 'Unknown Window'. self assert: windowRecord activePeriods size equals: 2. From cd0cee6bca1772fa2eeb648374d3a7ec0f72a32b Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 14:18:50 +0200 Subject: [PATCH 8/9] fix: add tag to test classes --- DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st | 5 +++-- DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st | 5 +++-- DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st | 5 +++-- DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st | 5 +++-- DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st | 5 +++-- 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st index 34f4ac1..33f8861 100644 --- a/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSMouseEnterWindowRecordTest.class.st @@ -1,8 +1,9 @@ Class { #name : 'DSMouseEnterWindowRecordTest', #superclass : 'TestCase', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' + #category : 'DebuggingSpy-Tests-Tests - model', + #package : 'DebuggingSpy-Tests', + #tag : 'Tests - model' } { #category : 'tests' } diff --git a/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st index 47660fb..73795d7 100644 --- a/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st +++ b/DebuggingSpy-Tests/DSMouseLeaveWindowRecordTest.class.st @@ -1,8 +1,9 @@ Class { #name : 'DSMouseLeaveWindowRecordTest', #superclass : 'TestCase', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' + #category : 'DebuggingSpy-Tests-Tests - model', + #package : 'DebuggingSpy-Tests', + #tag : 'Tests - model' } { #category : 'tests' } diff --git a/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st index 40eaed2..97a31b7 100644 --- a/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowActivatedRecordTest.class.st @@ -1,8 +1,9 @@ Class { #name : 'DSWindowActivatedRecordTest', #superclass : 'TestCase', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' + #category : 'DebuggingSpy-Tests-Tests - model', + #package : 'DebuggingSpy-Tests', + #tag : 'Tests - model' } { #category : 'tests' } diff --git a/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st index 2731247..2a650bc 100644 --- a/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowClosedRecordTest.class.st @@ -1,8 +1,9 @@ Class { #name : 'DSWindowClosedRecordTest', #superclass : 'TestCase', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' + #category : 'DebuggingSpy-Tests-Tests - model', + #package : 'DebuggingSpy-Tests', + #tag : 'Tests - model' } { #category : 'tests' } diff --git a/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st index 8c1e781..bc806df 100644 --- a/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st +++ b/DebuggingSpy-Tests/DSWindowOpenedRecordTest.class.st @@ -1,8 +1,9 @@ Class { #name : 'DSWindowOpenedRecordTest', #superclass : 'TestCase', - #category : 'DebuggingSpy-Tests', - #package : 'DebuggingSpy-Tests' + #category : 'DebuggingSpy-Tests-Tests - model', + #package : 'DebuggingSpy-Tests', + #tag : 'Tests - model' } { #category : 'tests' } From f9da07d8f5afa634e2a0f34cca892ac722e42a41 Mon Sep 17 00:00:00 2001 From: Nicolas Potel Date: Mon, 20 Apr 2026 14:28:22 +0200 Subject: [PATCH 9/9] fix: resize timer window --- DebuggingSpy-Browser/DSTimerWindow.class.st | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/DebuggingSpy-Browser/DSTimerWindow.class.st b/DebuggingSpy-Browser/DSTimerWindow.class.st index d35dfab..ef28e13 100644 --- a/DebuggingSpy-Browser/DSTimerWindow.class.st +++ b/DebuggingSpy-Browser/DSTimerWindow.class.st @@ -46,7 +46,7 @@ DSTimerWindow >> currentTimeMorph [ ^ StringMorph new contents: Time now print24; - position: 335 @ 6 + position: 425 @ 6 ] { #category : 'timer' } @@ -186,14 +186,14 @@ DSTimerWindow >> recordingIcon [ ^ ImageMorph new image: (self iconNamed: #glamorousRedCircle); - position: 260 @ 7; + position: 350 @ 7; yourself ] { #category : 'accessing' } DSTimerWindow >> size [ - ^ 410 @ 30 + ^ 500 @ 30 ] { #category : 'accessing' } @@ -224,7 +224,7 @@ DSTimerWindow >> stopButton [ label: (IconicListItemMorph new icon: (self iconNamed: #stop)); model: self; actionSelector: #stopTimer; - position: 385 @ 4; + position: 475 @ 4; yourself ] @@ -241,7 +241,7 @@ DSTimerWindow >> timerMorph [ ^ StringMorph new contents: '00:00:00'; - position: 275 @ 6 + position: 365 @ 6 ] { #category : 'private - layout' }