Skip to content

Commit 3f20cf2

Browse files
committed
Colormaps: small/large icons are now both horizontal
1 parent 39ca9ae commit 3f20cf2

3 files changed

Lines changed: 22 additions & 16 deletions

File tree

plotpy/mathutils/colormaps.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
from plotpy.widgets.colormap.widget import EditableColormap
4949

5050
FULLRANGE = QwtInterval(0.0, 1.0)
51-
SQUARE_ICON_SIZE = 16
52-
RECT_ICON_SIZE_W, RECT_ICON_SIZE_H = 80, 16
51+
SMALL_ICON_WIDTH, SMALL_ICON_HEIGHT, SMALL_ICON_ORIENTATION = 16, 7, "h"
52+
LARGE_ICON_WIDTH, LARGE_ICON_HEIGHT, LARGE_ICON_ORIENTATION = 80, 16, "h"
5353

5454
CmapDictType = Dict[str, EditableColormap]
5555

@@ -167,9 +167,9 @@ def save_colormaps(json_filename: str, colormaps: CmapDictType):
167167

168168
def build_icon_from_cmap(
169169
cmap: EditableColormap,
170-
width: int = SQUARE_ICON_SIZE,
171-
height: int = SQUARE_ICON_SIZE,
172-
orientation: Literal["h", "v"] = "v",
170+
width: int = SMALL_ICON_WIDTH,
171+
height: int = SMALL_ICON_HEIGHT,
172+
orientation: Literal["h", "v"] = SMALL_ICON_ORIENTATION,
173173
margin: int = 0,
174174
) -> QG.QIcon:
175175
"""Builds an icon representing the colormap
@@ -220,9 +220,9 @@ def build_icon_from_cmap(
220220

221221
def build_icon_from_cmap_name(
222222
cmap_name: str,
223-
width: int = SQUARE_ICON_SIZE,
224-
height: int = SQUARE_ICON_SIZE,
225-
orientation: Literal["h", "v"] = "v",
223+
width: int = SMALL_ICON_WIDTH,
224+
height: int = SMALL_ICON_HEIGHT,
225+
orientation: Literal["h", "v"] = SMALL_ICON_ORIENTATION,
226226
margin: int = 0,
227227
) -> QG.QIcon:
228228
"""Builds an QIcon representing the colormap from the colormap name found in

plotpy/styles/image.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@
2525
from plotpy.constants import LUTAlpha
2626
from plotpy.mathutils.colormaps import (
2727
ALL_COLORMAPS,
28-
RECT_ICON_SIZE_H,
29-
RECT_ICON_SIZE_W,
28+
LARGE_ICON_HEIGHT,
29+
LARGE_ICON_ORIENTATION,
30+
LARGE_ICON_WIDTH,
3031
build_icon_from_cmap_name,
3132
)
3233
from plotpy.styles.base import ItemParameters
@@ -46,7 +47,11 @@ def _create_choices(
4647
cmap.name,
4748
cmap.name,
4849
lambda name: build_icon_from_cmap_name(
49-
name, RECT_ICON_SIZE_W, RECT_ICON_SIZE_H, "h", 1
50+
name,
51+
LARGE_ICON_WIDTH,
52+
LARGE_ICON_HEIGHT,
53+
LARGE_ICON_ORIENTATION,
54+
1,
5055
),
5156
)
5257
)
@@ -75,7 +80,7 @@ class BaseImageParam(DataSet):
7580
colormap = (
7681
ImageChoiceItem(_("Colormap"), _create_choices, default="jet")
7782
.set_prop("display", hide=GetAttrProp("_hide_colormap"))
78-
.set_prop("display", size=(RECT_ICON_SIZE_W, RECT_ICON_SIZE_H))
83+
.set_prop("display", size=(LARGE_ICON_WIDTH, LARGE_ICON_HEIGHT))
7984
)
8085

8186
interpolation = ChoiceItem(

plotpy/widgets/colormap/manager.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@
3535
ALL_COLORMAPS,
3636
CUSTOM_COLORMAPS,
3737
DEFAULT_COLORMAPS,
38-
RECT_ICON_SIZE_H,
39-
RECT_ICON_SIZE_W,
38+
LARGE_ICON_HEIGHT,
39+
LARGE_ICON_ORIENTATION,
40+
LARGE_ICON_WIDTH,
4041
add_cmap,
4142
build_icon_from_cmap,
4243
cmap_exists,
@@ -134,11 +135,11 @@ def __init__(
134135
self._cmap_choice.setMaxVisibleItems(15)
135136
for cmap in ALL_COLORMAPS.values():
136137
icon = build_icon_from_cmap(
137-
cmap, RECT_ICON_SIZE_W, RECT_ICON_SIZE_H, "h", 1
138+
cmap, LARGE_ICON_WIDTH, LARGE_ICON_HEIGHT, LARGE_ICON_ORIENTATION, 1
138139
)
139140
self._cmap_choice.addItem(icon, cmap.name, cmap)
140141

141-
self._cmap_choice.setIconSize(QC.QSize(RECT_ICON_SIZE_W, RECT_ICON_SIZE_H))
142+
self._cmap_choice.setIconSize(QC.QSize(LARGE_ICON_WIDTH, LARGE_ICON_HEIGHT))
142143
self._cmap_choice.setCurrentText(active_colormap)
143144
select_gbox = QW.QGroupBox(_("Select or create a colormap"))
144145
select_label = QW.QLabel(_("Colormap presets:"))

0 commit comments

Comments
 (0)