Colormap manager: prevent active color map removal

Author: PierreRaybaut

plotpy/locale/fr/LC_MESSAGES/plotpy.mo

@@ -6,7 +6,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: \n"
-"POT-Creation-Date: 2024-03-01 09:20+0100\n"
+"POT-Creation-Date: 2024-03-01 09:45+0100\n"
 "PO-Revision-Date: 2019-02-20 14:42+0100\n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -401,9 +401,9 @@ msgstr "Déplacer vers le premier plan"
 
 #: plotpy\panels\itemlist.py:94 plotpy\panels\itemlist.py:236
 #: plotpy\tools\item.py:154 plotpy\tools\item.py:179
-#: plotpy\widgets\colormap\manager.py:155
-#: plotpy\widgets\colormap\manager.py:320
-#: plotpy\widgets\colormap\manager.py:329
+#: plotpy\widgets\colormap\manager.py:166
+#: plotpy\widgets\colormap\manager.py:338
+#: plotpy\widgets\colormap\manager.py:346
 msgid "Remove"
 msgstr "Supprimer"
 
@@ -2044,62 +2044,68 @@ msgstr ""
 "Un nom de colormap ne peut pas contenir de caractères spéciauxexcepté les "
 "tirets bas (_)."
 
-#: plotpy\widgets\colormap\manager.py:134
+#: plotpy\widgets\colormap\manager.py:143
 msgid "Colormap manager"
 msgstr "Gestionnaire de palettes de couleurs"
 
-#: plotpy\widgets\colormap\manager.py:153
+#: plotpy\widgets\colormap\manager.py:164
 msgid "Add"
 msgstr "Ajouter"
 
-#: plotpy\widgets\colormap\manager.py:160
+#: plotpy\widgets\colormap\manager.py:171
 msgid "Select or create a colormap"
 msgstr "Sélectionner ou créer une palette de couleurs"
 
-#: plotpy\widgets\colormap\manager.py:161
+#: plotpy\widgets\colormap\manager.py:172
 msgid "Colormap presets:"
 msgstr "Palettes de couleurs prédéfinies :"
 
-#: plotpy\widgets\colormap\manager.py:174
+#: plotpy\widgets\colormap\manager.py:185
 msgid "Edit the selected colormap"
 msgstr "Modifier la palette de couleurs sélectionnée"
 
-#: plotpy\widgets\colormap\manager.py:281
+#: plotpy\widgets\colormap\manager.py:291
 msgid ""
-"Name <b>%s</b> is already used by a default colormap, and cannot be used for "
-"a custom colormap.<br><br>Please choose another name."
+"Name <b>%s</b> is already used by a predefined colormap, and cannot be used "
+"for a custom colormap.<br><br>Please choose another name."
 msgstr ""
-"Le nom <b>%s</b> est déjà utilisé par une palette de couleurs par défaut, et "
-"ne peut pas être utilisé pour une palette de couleurs personnalisée."
-"<br><br>Veuillez choisir un autre nom."
+"Le nom <b>%s</b> est déjà utilisé par une palette de couleurs prédéfinie, et "
+"ne peut pas être utilisé pour une palette personnalisée.<br><br>Veuillez "
+"choisir un autre nom."
 
-#: plotpy\widgets\colormap\manager.py:293
+#: plotpy\widgets\colormap\manager.py:303
 msgid ""
 "Name <b>%s</b> is already used by a custom colormap.<br><br>Do you want to "
 "overwrite it?"
 msgstr ""
 "Le nom <b>%s</b> est déjà utilisé par une palette de couleurs personnalisée."
 "<br><br>Voulez-vous l'écraser ?"
 
-#: plotpy\widgets\colormap\manager.py:309
+#: plotpy\widgets\colormap\manager.py:319
 msgid "New"
 msgstr "Nouveau"
 
-#: plotpy\widgets\colormap\manager.py:321
-msgid "Colormap <b>%s</b> is a default colormap and cannot be deleted."
-msgstr ""
-"La palette de couleurs <b>%s</b> est une palette par défaut et ne peut pas "
-"être supprimée."
+#: plotpy\widgets\colormap\manager.py:333
+msgid "Colormap <b>%s</b> is the active colormap."
+msgstr "La palette de couleurs <b>%s</b> est la palette active."
+
+#: plotpy\widgets\colormap\manager.py:335
+msgid "Colormap <b>%s</b> is a predefined colormap."
+msgstr "La palette de couleurs <b>%s</b> est une palette prédéfinie."
 
-#: plotpy\widgets\colormap\manager.py:330
+#: plotpy\widgets\colormap\manager.py:339
+msgid "Thus, this colormap cannot be removed."
+msgstr "Cette palette de couleurs ne peut donc pas être supprimée."
+
+#: plotpy\widgets\colormap\manager.py:347
 msgid "Do you want to delete colormap <b>%s</b>?"
 msgstr "Souhaitez-vous supprimer la palette de couleurs <b>%s</b> ?"
 
-#: plotpy\widgets\colormap\manager.py:356
+#: plotpy\widgets\colormap\manager.py:373
 msgid "Save colormap"
 msgstr "Enregistrer la palette de couleurs"
 
-#: plotpy\widgets\colormap\manager.py:358
+#: plotpy\widgets\colormap\manager.py:375
 msgid "Add colormap"
 msgstr "Ajouter une palette de couleurs"
 
@@ -2264,37 +2270,3 @@ msgstr "Rotation et rognage"
 #: plotpy\widgets\rotatecrop.py:219
 msgid "Show cropping rectangle"
 msgstr "Afficher le rectangle de rognage"
-
-#~ msgid "Save"
-#~ msgstr "Enregistrer"
-
-#~ msgid "Delete colormap"
-#~ msgstr "Supprimer la palette de couleurs"
-
-#~ msgid "Create new colormap"
-#~ msgstr "Créer une nouvelle palette de couleurs"
-
-#~ msgid "Custom colormap %s already exists, do you want to overwrite it?"
-#~ msgstr ""
-#~ "La palette de couleurs personnalisée %s existe déjà, voulez-vous "
-#~ "l'écraser ?"
-
-#~ msgid ""
-#~ "New colormap \"%s\" is a default colormap and cannot be overwritten. "
-#~ "Change its name to save it as a custom colormap."
-#~ msgstr ""
-#~ "La nouvelle table des couleurs \"%s\" est une table des couleurs par "
-#~ "défaut et ne peut pas être remplacée. Modifiez son nom pour l'enregistrer "
-#~ "en tant que carte de couleurs personnalisée."
-
-#~ msgid "Close"
-#~ msgstr "Fermer"
-
-#~ msgid ""
-#~ "Current changes not saved. The current colormap will be discarded when "
-#~ "the editor is closed.\n"
-#~ "Do you want to save the changes?"
-#~ msgstr ""
-#~ "Les modifications actuelles ne sont pas sauvegardées. La palette de "
-#~ "couleurs actuelle sera supprimée lorsque l'éditeur éditeur sera fermé.\n"
-#~ "Voulez-vous enregistrer les modifications ?"

plotpy/locale/fr/LC_MESSAGES/plotpy.po

@@ -5,7 +5,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
-"POT-Creation-Date: 2024-03-01 09:20+0100\n"
+"POT-Creation-Date: 2024-03-01 09:45+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -378,9 +378,9 @@ msgstr ""
 
 #: plotpy\panels\itemlist.py:94 plotpy\panels\itemlist.py:236
 #: plotpy\tools\item.py:154 plotpy\tools\item.py:179
-#: plotpy\widgets\colormap\manager.py:155
-#: plotpy\widgets\colormap\manager.py:320
-#: plotpy\widgets\colormap\manager.py:329
+#: plotpy\widgets\colormap\manager.py:166
+#: plotpy\widgets\colormap\manager.py:338
+#: plotpy\widgets\colormap\manager.py:346
 msgid "Remove"
 msgstr ""
 
@@ -1981,51 +1981,59 @@ msgstr ""
 msgid "New colormap name cannot contain special characters except underscores (_)."
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:134
+#: plotpy\widgets\colormap\manager.py:143
 msgid "Colormap manager"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:153
+#: plotpy\widgets\colormap\manager.py:164
 msgid "Add"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:160
+#: plotpy\widgets\colormap\manager.py:171
 msgid "Select or create a colormap"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:161
+#: plotpy\widgets\colormap\manager.py:172
 msgid "Colormap presets:"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:174
+#: plotpy\widgets\colormap\manager.py:185
 msgid "Edit the selected colormap"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:281
-msgid "Name <b>%s</b> is already used by a default colormap, and cannot be used for a custom colormap.<br><br>Please choose another name."
+#: plotpy\widgets\colormap\manager.py:291
+msgid "Name <b>%s</b> is already used by a predefined colormap, and cannot be used for a custom colormap.<br><br>Please choose another name."
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:293
+#: plotpy\widgets\colormap\manager.py:303
 msgid "Name <b>%s</b> is already used by a custom colormap.<br><br>Do you want to overwrite it?"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:309
+#: plotpy\widgets\colormap\manager.py:319
 msgid "New"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:321
-msgid "Colormap <b>%s</b> is a default colormap and cannot be deleted."
+#: plotpy\widgets\colormap\manager.py:333
+msgid "Colormap <b>%s</b> is the active colormap."
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:330
+#: plotpy\widgets\colormap\manager.py:335
+msgid "Colormap <b>%s</b> is a predefined colormap."
+msgstr ""
+
+#: plotpy\widgets\colormap\manager.py:339
+msgid "Thus, this colormap cannot be removed."
+msgstr ""
+
+#: plotpy\widgets\colormap\manager.py:347
 msgid "Do you want to delete colormap <b>%s</b>?"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:356
+#: plotpy\widgets\colormap\manager.py:373
 msgid "Save colormap"
 msgstr ""
 
-#: plotpy\widgets\colormap\manager.py:358
+#: plotpy\widgets\colormap\manager.py:375
 msgid "Add colormap"
 msgstr ""
 

plotpy/locale/plotpy.pot

@@ -120,8 +120,17 @@ class ColorMapManager(QW.QDialog):
 
     Args:
         parent: parent QWidget. Defaults to None.
-        active_colormap: name of the default colormap selected. If None or does not
-         *exists, will defaults to the first colormap in the list. Defaults to None
+        active_colormap: name of the active colormap.
+
+    .. note::
+
+        The active colormap is the colormap that will be selected by default when the
+        dialog box is opened. If the colormap does not exist (or if None is provided),
+        the first colormap in the list will be selected by default.
+
+        The active colormap cannot be removed. If the active colormap is a custom
+        colormap, the remove button will be enabled but a dialog box will warn the user
+        that the colormap cannot be removed.
     """
 
     def __init__(
@@ -133,10 +142,12 @@ def __init__(
         self.setWindowIcon(get_icon("cmap_edit.png"))
         self.setWindowTitle(_("Colormap manager"))
 
+        self.active_cmap_name = default_colormap = active_colormap
+
         self.__returned_colormap: EditableColormap | None = None
 
-        if active_colormap is None or not cmap_exists(active_colormap, ALL_COLORMAPS):
-            active_colormap = next(iter(ALL_COLORMAPS))
+        if default_colormap is None or not cmap_exists(default_colormap, ALL_COLORMAPS):
+            default_colormap = next(iter(ALL_COLORMAPS))
 
         # Select the active colormap
         self._cmap_choice = QW.QComboBox()
@@ -148,12 +159,12 @@ def __init__(
             self._cmap_choice.addItem(icon, cmap.name, cmap)
 
         self._cmap_choice.setIconSize(QC.QSize(LARGE_ICON_WIDTH, LARGE_ICON_HEIGHT))
-        self._cmap_choice.setCurrentText(active_colormap)
+        self._cmap_choice.setCurrentText(default_colormap)
 
         add_btn = QW.QPushButton(get_icon("edit_add.png"), _("Add") + "...")
         add_btn.clicked.connect(self.add_colormap)
         self._remove_btn = QW.QPushButton(get_icon("delete.png"), _("Remove") + "...")
-        is_custom_cmap = cmap_exists(active_colormap, CUSTOM_COLORMAPS)
+        is_custom_cmap = cmap_exists(default_colormap, CUSTOM_COLORMAPS)
         self._remove_btn.setEnabled(is_custom_cmap)
         self._remove_btn.clicked.connect(self.remove_colormap)
 
@@ -278,7 +289,7 @@ def __get_new_colormap_name(self, title: str, name: str) -> str | None:
                     self,
                     title,
                     _(
-                        "Name <b>%s</b> is already used by a default colormap, and "
+                        "Name <b>%s</b> is already used by a predefined colormap, and "
                         "cannot be used for a custom colormap.<br><br>"
                         "Please choose another name."
                     )
@@ -317,20 +328,24 @@ def remove_colormap(self) -> None:
         cmap = self.colormap_editor.get_colormap()
         if cmap is None:
             return
-        if cmap_exists(cmap.name, DEFAULT_COLORMAPS):
+        name = cmap.name
+        if name == self.active_cmap_name or cmap_exists(name, DEFAULT_COLORMAPS):
+            if name == self.active_cmap_name:
+                msg = _("Colormap <b>%s</b> is the active colormap.")
+            else:
+                msg = _("Colormap <b>%s</b> is a predefined colormap.")
             QW.QMessageBox.warning(
                 self,
                 _("Remove"),
-                _("Colormap <b>%s</b> is a default colormap and cannot be deleted.")
-                % cmap.name,
+                msg % name + "<br>" + _("Thus, this colormap cannot be removed."),
                 QW.QMessageBox.Ok,
             )
             return
         if (
             QW.QMessageBox.question(
                 self,
                 _("Remove"),
-                _("Do you want to delete colormap <b>%s</b>?") % cmap.name,
+                _("Do you want to delete colormap <b>%s</b>?") % name,
                 QW.QMessageBox.Yes | QW.QMessageBox.No,
                 QW.QMessageBox.No,
             )